Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserStory] Notify Users of an unrecognizable file type and let user select a new file #83

Open
5 tasks done
ShayneKaiser opened this issue Oct 13, 2021 · 8 comments
Open
5 tasks done
Assignees
Labels
enhancement New feature or request user story User Story

Comments

@ShayneKaiser
Copy link

User Story

Essential components

  • Title describes the story
  • Stakeholder type is identified
  • Outcome is described
  • Rationale is explicit
  • Acceptance criteria are verifiable and from the perspective of the stakeholder

Story

As a Imagelab user
I want to be notified that the type of the file I selected was not recognized by Imagelab and I am allowed to select a new file
so that I know why the file wasn't opened and I'm able to continue using Imagelab in the same instance.

Acceptance Criteria

  • When a user selects a file type not recognized by Imagelab they are notified that the file type is not recognized by Imagelab
  • After a user is notified that a file type was not recognized, the user is able to select a new file

Scenario 1

Given a user in Imagelab selects an image file by navigating to File > Open
when a file type not recognized by Imagelab is selected
then the user is notified that the file type is unrecognized and the user is able to select another file.

@JoeSGunter
Copy link

@ShayneKaiser @Codyhintzch @ColinLouis95 and myself trying to tackle this issue.

We believe the issue with the program seizing when an unrecognized file is selected is surrounding line 82 of the DisplayImage.java file and the while loops thereafter not having a case for a null pixel value.

@lonespartan12
Copy link

Allowing imagelab to accept all java compatible file is a good place to start. then throwing an exception after testing file type.

@jody
Copy link
Contributor

jody commented Oct 21, 2021

throwing an exception

Because choosing a file of incompatible type is an expected behavior of the user, the suggested handling is by the program logic directly (rather than using the exception mechanism).

@JoeSGunter
Copy link

Unable to resolve this issue in time - we believe this problem is hand in hand with closing file dialog window seizing the program.

@CameronSpear
Copy link

CameronSpear commented Oct 3, 2023

@ThomasD0123 @CamiJolly1 @KaizenPool and myself are working on this issue
We are starting down a couple different paths to try and find the exact source of the issue and will comment further as we narrow in on the source of the problem and come up with a fix

@ThomasD0213
Copy link

Assign me too please!

@CamiJolly1
Copy link
Contributor

me three!

@KaizenPool
Copy link

@ThomasD0123 @CamiJolly1 @KaizenPool and myself are working on this issue We are starting down a couple different paths to try and find the exact source of the issue and will comment further as we narrow in on the source of the problem and come up with a fix

KaizenPool added a commit to KaizenPool/imagelab that referenced this issue Oct 15, 2023
…elected is not the right file type it freezes. the goal of this commit to fix this problem. It also worked help fix issue MetroCS#70 that says when you click cancel on the dialog window the program crashes. This update that was focused on fix issue MetroCS#83 also fixe issue MetroCS#70. The fix to issue MetroCS#83 is not complete. It is eable to discern between the right type of file extension. It does not send a message to the user that it is the wrong file type, but it does allow the user to select another file. I worked on this edit on bluej and Mac OS
@CamiJolly1 CamiJolly1 removed their assignment Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user story User Story
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

8 participants