Resolution for issue #70 #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks to make sure the file explorer is returning value outputs. One check ensures it is an image file, the other makes sure a null is not returned which happens when the explorer is closed without selecting a file. Both checks might be able to be condensed down to one check and we might be able to add a GUI popup instead of just a System.out on check failure.
No need to have an else block. If the user cancels out of the file explorer they don't need to be told they did so.
Fixed both reported bugs involving the file explorer
The bug report for trying to open a none image file was rejected. Removing lines to check file extension.
The bug report for trying to open a none image file was rejected. Removing lines to check file extension.
jbae-89
reviewed
Oct 14, 2021
There was a problem hiding this comment.
@KyleKing54
There is a method for filtering filetypes setFilenameFilter() as well as an open issue which will hopefully resolve how we should handle allowed filetypes and maybe even what to do if the files have the right extensions but wrong encoding. #83 and #69
I would recommend placing the if statement before assignment of theFile and then checking the condition of fd.getFile() == null
The else statements provide stdout but this is a GUI program.
Removed debugging on line 293
Removed debugging on line 293 that is no longer in use.
jody
requested changes
Oct 16, 2021
There was a problem hiding this comment.
Looks great!
Please update the version number by adding a digit to make the file version distinct (1.8.3.1).
Then please squash all the individual commits.
After this, I believe we're good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The program becomes unresponsive after closing the file explorer to select an image file without selecting a file. Added a check to make sure the explorer does not return a null value before attempting to process the image further, preventing the program from freezing up when you click cancel.