Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak, not calling VMMDLL_MemFree with the VMMDLL_Map_GetVadW call. #29

Open
kweatherman opened this issue Dec 24, 2024 · 0 comments

Comments

@kweatherman
Copy link

kweatherman commented Dec 24, 2024

Not a big deal, but you call VMMDLL_Map_GetVadW without a matching VMMDLL_MemFree call.

Not sure how often get_memory_region gets called, but it will result in a memory leak each time.
If it's only called once not an issue since as we know all allocations get killed on process exit.

Just need to add a VMMDLL_MemFree before returning from get_memory_region().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant