Fix: Incorrect Fee Estimation Due to Omitted estimate_mode in Bitcoin Core 28.0

Author: juanmigdr

NBitcoin/RPC/RPCClient.cs

@@ -395,7 +395,7 @@ async static Task CheckSegwitCapabilitiesAsync(RPCClient rpc, Action<bool> setRe
 				return;
 			}
 #endif
-				var address = new Key().GetAddress(type, rpc.Network);
+			var address = new Key().GetAddress(type, rpc.Network);
 			if (address == null)
 			{
 				setResult(false);
@@ -1059,7 +1059,7 @@ private async Task<Stream> ToMemoryStreamAsync(Stream stream)
 			return ms;
 		}
 
-#region P2P Networking
+		#region P2P Networking
 #if !NOSOCKET
 		public PeerInfo[] GetPeersInfo()
 		{
@@ -1211,9 +1211,9 @@ public async Task<AddedNodeInfo> GetAddedNodeInfoAync(bool detailed, EndPoint no
 		}
 #endif
 
-#endregion
+		#endregion
 
-#region Block chain and UTXO
+		#region Block chain and UTXO
 
 		public async Task<BlockchainInfo> GetBlockchainInfoAsync(CancellationToken cancellationToken = default)
 		{
@@ -1868,13 +1868,13 @@ public IEnumerable<Transaction> GetTransactions(int height)
 			return GetTransactions(GetBlockHash(height));
 		}
 
-#endregion
+		#endregion
 
-#region Coin generation
+		#region Coin generation
 
-#endregion
+		#endregion
 
-#region Raw Transaction
+		#region Raw Transaction
 
 		public Transaction DecodeRawTransaction(string rawHex)
 		{
@@ -2011,15 +2011,15 @@ public async Task<BumpResponse> BumpFeeAsync(uint256 txid, CancellationToken can
 		}
 
 
-#endregion
+		#endregion
 
-#region Utility functions
+		#region Utility functions
 
 		// Estimates the approximate fee per kilobyte needed for a transaction to begin
 		// confirmation within conf_target blocks if possible and return the number of blocks
 		// for which the estimate is valid.Uses virtual transaction size as defined
 		// in BIP 141 (witness data is discounted).
-#region Fee Estimation
+		#region Fee Estimation
 
 		/// <summary>
 		/// (>= Bitcoin Core v0.14) Get the estimated fee per kb for being confirmed in nblock
@@ -2081,13 +2081,9 @@ private async Task<EstimateSmartFeeResponse> EstimateSmartFeeImplAsync(int confi
 		{
 			if (Capabilities == null || Capabilities.SupportEstimateSmartFee)
 			{
-				var parameters = new List<object>() { confirmationTarget };
-				if (estimateMode != EstimateSmartFeeMode.Conservative)
-				{
-					parameters.Add(estimateMode.ToString().ToUpperInvariant());
-				}
+				var parameters = new object[] { confirmationTarget, estimateMode.ToString().ToUpperInvariant() };
 
-				var request = new RPCRequest(RPCOperations.estimatesmartfee.ToString(), parameters.ToArray());
+				var request = new RPCRequest(RPCOperations.estimatesmartfee.ToString(), parameters);
 				request.ThrowIfRPCError = false;
 				var response = await SendCommandAsync(request, cancellationToken: cancellationToken).ConfigureAwait(false);
 
@@ -2132,7 +2128,7 @@ private async Task<EstimateSmartFeeResponse> EstimateSmartFeeImplAsync(int confi
 			}
 		}
 
-#endregion
+		#endregion
 
 
 #nullable enable
@@ -2318,7 +2314,7 @@ public bool SetTxFee(FeeRate feeRate, CancellationToken cancellationToken = defa
 			return SendCommand(RPCOperations.settxfee, cancellationToken, new[] { feeRate.FeePerK.ToString() }).Result.ToString() == "true";
 		}
 
-#endregion
+		#endregion
 
 		public async Task<uint256[]> GenerateAsync(int nBlocks, CancellationToken cancellationToken = default)
 		{
@@ -2369,7 +2365,7 @@ public uint256[] GenerateToAddress(int nBlocks, BitcoinAddress address)
 			return GenerateToAddressAsync(nBlocks, address).GetAwaiter().GetResult();
 		}
 
-#region Region Hidden Methods
+		#region Region Hidden Methods
 
 		/// <summary>
 		/// Permanently marks a block as invalid, as if it violated a consensus rule.
@@ -2415,7 +2411,7 @@ public async Task<bool> AddPeerAddressAsync(IPAddress ip, int port, Cancellation
 
 #endif
 
-#endregion
+		#endregion
 	}
 
 #if !NOSOCKET