Skip to content

Commit 97ba5d6

Browse files
authored
chore: Update @metamask/signature-controller (#20202)
## **Description** Updates the dependency on @metamask/signature-controller to 34.0.0 This version bump introduces a dependency on @metamask/gator-permissions-controller via `GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction` which has been added to signature-controller-messenger. ## **Changelog** From SignatureController https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md: ### @metamask/signature-controller 34.0.0 #### Added - Add two new controller state metadata properties: includeInStateLogs and usedInUi (MetaMask/core#6473) - Decode delegation permissions using `@metamask/gator-permissions-controller` when calling `newUnsignedTypedMessage` ([#6619](MetaMask/core#6619)) #### Changed - Bump @metamask/controller-utils from ^11.12.0 to ^11.14.0 (MetaMask/core#6620, MetaMask/core#6629) - Bump @metamask/base-controller from ^8.1.0 to ^8.4.0 (MetaMask/core#6355, MetaMask/core#6465, MetaMask/core#6632) - Bump @metamask/utils from ^11.4.2 to ^11.8.0 (MetaMask/core#6588) ### @metamask/signature-controller 33.0.0 #### Changed - BREAKING: Bump peer dependency @metamask/accounts-controller from ^32.0.0 to ^33.0.0 (MetaMask/core#6345) - BREAKING: Bump peer dependency @metamask/keyring-controller from ^22.0.0 to ^23.0.0 (MetaMask/core#6345) - Bump @metamask/base-controller from ^8.0.1 to ^8.1.0 (MetaMask/core#6284) - Bump @metamask/controller-utils from ^11.11.0 to ^11.12.0 (MetaMask/core#6303) CHANGELOG entry: null ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade @metamask/signature-controller to ^34 and allow GatorPermissionsController decode action in the signature controller messenger. > > - **Dependencies**: > - Bump `@metamask/signature-controller` to `^34.0.0`. > - **Engine**: > - **`app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts`**: > - Add `GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction` and allow `GatorPermissionsController:decodePermissionFromPermissionContextForOrigin` in `allowedActions`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 657705e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 2244a39 commit 97ba5d6

File tree

4 files changed

+17
-12
lines changed

4 files changed

+17
-12
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,9 @@ app/components/Views/Onboarding @MetaMask/web3auth
220220
app/reducers/onboarding @MetaMask/web3auth
221221

222222
# Delegation team
223-
app/core/Engine/controllers/gator-permissions-controller @MetaMask/delegation
224-
app/core/Engine/messengers/gator-permissions-controller-messenger @MetaMask/delegation
223+
app/core/Engine/controllers/gator-permissions-controller @MetaMask/delegation
224+
app/core/Engine/messengers/gator-permissions-controller-messenger @MetaMask/delegation
225+
225226
# QA Team - E2E Framework
226227
e2e/api-mocking/ @MetaMask/qa
227228
e2e/fixtures/ @MetaMask/qa

app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
import { NetworkControllerGetNetworkClientByIdAction } from '@metamask/network-controller';
1111

1212
import type { SignatureControllerMessenger } from '@metamask/signature-controller';
13+
import { GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction } from '@metamask/gator-permissions-controller';
1314

1415
type MessengerActions =
1516
| AccountsControllerGetStateAction
@@ -18,7 +19,8 @@ type MessengerActions =
1819
| NetworkControllerGetNetworkClientByIdAction
1920
| KeyringControllerSignMessageAction
2021
| KeyringControllerSignPersonalMessageAction
21-
| KeyringControllerSignTypedMessageAction;
22+
| KeyringControllerSignTypedMessageAction
23+
| GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction;
2224

2325
type MessengerEvents = never;
2426

@@ -35,6 +37,7 @@ export function getSignatureControllerMessenger(
3537
'KeyringController:signMessage',
3638
'KeyringController:signPersonalMessage',
3739
'KeyringController:signTypedMessage',
40+
'GatorPermissionsController:decodePermissionFromPermissionContextForOrigin',
3841
],
3942
allowedEvents: [],
4043
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@
281281
"@metamask/sdk-communication-layer": "0.33.1",
282282
"@metamask/seedless-onboarding-controller": "^4.0.0",
283283
"@metamask/selected-network-controller": "^24.0.0",
284-
"@metamask/signature-controller": "^33.0.0",
284+
"@metamask/signature-controller": "^34.0.0",
285285
"@metamask/slip44": "^4.2.0",
286286
"@metamask/smart-transactions-controller": "^19.2.1",
287287
"@metamask/snaps-controllers": "^15.0.2",

yarn.lock

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8504,24 +8504,25 @@ __metadata:
85048504
languageName: node
85058505
linkType: hard
85068506

8507-
"@metamask/signature-controller@npm:^33.0.0":
8508-
version: 33.0.0
8509-
resolution: "@metamask/signature-controller@npm:33.0.0"
8507+
"@metamask/signature-controller@npm:^34.0.0":
8508+
version: 34.0.1
8509+
resolution: "@metamask/signature-controller@npm:34.0.1"
85108510
dependencies:
8511-
"@metamask/base-controller": "npm:^8.1.0"
8512-
"@metamask/controller-utils": "npm:^11.12.0"
8511+
"@metamask/base-controller": "npm:^8.4.1"
8512+
"@metamask/controller-utils": "npm:^11.14.1"
85138513
"@metamask/eth-sig-util": "npm:^8.2.0"
8514-
"@metamask/utils": "npm:^11.4.2"
8514+
"@metamask/utils": "npm:^11.8.1"
85158515
jsonschema: "npm:^1.4.1"
85168516
lodash: "npm:^4.17.21"
85178517
uuid: "npm:^8.3.2"
85188518
peerDependencies:
85198519
"@metamask/accounts-controller": ^33.0.0
85208520
"@metamask/approval-controller": ^7.0.0
8521+
"@metamask/gator-permissions-controller": ^0.2.0
85218522
"@metamask/keyring-controller": ^23.0.0
85228523
"@metamask/logging-controller": ^6.0.0
85238524
"@metamask/network-controller": ^24.0.0
8524-
checksum: 10/9fb0c33fd14dba0d7389fbe581c6cdd8f92870aaaebe92fc610e16b591572bea025760d5dbd87d35a3c4408936fb08cc163623d6f22bfbd36f3921178f8688e5
8525+
checksum: 10/ea6df5afeb99f5859ab7ab3cc50cf67827b87907932e429dbff37f65818a58a139348aab9c7b0870e0d68f2ca1b5763afa1677722e50bf5179923b6dd6573f9a
85258526
languageName: node
85268527
linkType: hard
85278528

@@ -34181,7 +34182,7 @@ __metadata:
3418134182
"@metamask/sdk-communication-layer": "npm:0.33.1"
3418234183
"@metamask/seedless-onboarding-controller": "npm:^4.0.0"
3418334184
"@metamask/selected-network-controller": "npm:^24.0.0"
34184-
"@metamask/signature-controller": "npm:^33.0.0"
34185+
"@metamask/signature-controller": "npm:^34.0.0"
3418534186
"@metamask/slip44": "npm:^4.2.0"
3418634187
"@metamask/smart-transactions-controller": "npm:^19.2.1"
3418734188
"@metamask/snaps-controllers": "npm:^15.0.2"

0 commit comments

Comments
 (0)