Skip to content

Commit d1d41e0

Browse files
committed
test: Add missing test case
1 parent a43ed9c commit d1d41e0

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

packages/eth-json-rpc-provider/src/internal-provider.test.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jest.mock('uuid');
1919

2020
type ResultParam = Json | ((req?: JsonRpcRequest) => Json);
2121

22-
const createMockEngine = (method: string, result: ResultParam) => {
22+
const createEngine = (method: string, result: ResultParam) => {
2323
const engine = new JsonRpcEngine();
2424
engine.push((req, res, next, end) => {
2525
if (req.method === method) {
@@ -31,7 +31,7 @@ const createMockEngine = (method: string, result: ResultParam) => {
3131
return engine;
3232
};
3333

34-
const createMockServer = (method: string, result: ResultParam) => {
34+
const createServer = (method: string, result: ResultParam) => {
3535
const engine = JsonRpcEngineV2.create({
3636
middleware: [
3737
({ request, next }) => {
@@ -48,9 +48,18 @@ const createMockServer = (method: string, result: ResultParam) => {
4848
return server;
4949
};
5050

51+
describe('legacy constructor', () => {
52+
it('can be constructed with an engine', () => {
53+
const provider = new InternalProvider({
54+
engine: createEngine('eth_blockNumber', 42),
55+
});
56+
expect(provider).toBeDefined();
57+
});
58+
});
59+
5160
describe.each([
52-
{ createRpcHandler: createMockEngine, name: 'JsonRpcEngine' },
53-
{ createRpcHandler: createMockServer, name: 'JsonRpcServer' },
61+
{ createRpcHandler: createEngine, name: 'JsonRpcEngine' },
62+
{ createRpcHandler: createServer, name: 'JsonRpcServer' },
5463
])('InternalProvider with $name', ({ createRpcHandler }) => {
5564
it('returns the correct block number with @metamask/eth-query', async () => {
5665
const provider = new InternalProvider({

0 commit comments

Comments
 (0)