feat: New base-controller API (#6926)

## Explanation

The `@metamask/base-controller` package has been updated to use the new
API that had previously been exposed under the `next` export. Major
changes include:

- Remove `Messenger` and `RestrictedMessenger`
  - Replaced by the `@metamask/messenger` library
- Update `BaseController` to require `@metamask/messenger` instance
- Rename `anonymous` metadata property to `includeInDebugLogs`
- Make `includeInStateLogs` and `usedInUi` metadata properties required
- Remove `getPersistentState` and `getAnonymizedState`
- Remove `isBaseController`
- Rename `ListenerV2` to `StateChangeListener`
- Rename `messagingSystem` protected instance variable to `messenger`
- Remove `next` export

## References

Relates to #5626

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Migrate all packages to the new `@metamask/base-controller` API using
`@metamask/messenger`, remove the `/next` export and legacy messenger,
and update metadata types and configs accordingly.
> 
> - **base-controller (BREAKING)**:
> - Replace internal `Messenger`/`RestrictedMessenger` with
`@metamask/messenger`; `BaseController` now requires a `Messenger`
instance.
> - Remove `/next` export and legacy files (`src/next/*`, `next.js`,
`next.d.ts`).
> - Rename metadata `anonymous` -> `includeInDebugSnapshot`; require
`includeInStateLogs` and `usedInUi`.
> - Rename `ListenerV2` -> `StateChangeListener`; rename
`messagingSystem` -> `messenger`.
> - Remove `getPersistentState`, `getAnonymizedState`, and
`isBaseController`.
> - Update types and implementation to new messenger integration and
events.
>   - Update `CHANGELOG.md` with breaking changes.
> - **Repo-wide refactor**:
> - Change imports from `@metamask/base-controller/next` to
`@metamask/base-controller` across controllers/tests (accounts, assets,
network, permissions, transactions, etc.).
>   - Update tests to use `@metamask/messenger` and new metadata keys.
> - **Config/build**:
> - Remove Jest `moduleNameMapper` for `/next`; adjust TypeScript
`paths` and add `skipLibCheck` in `tsconfig.packages.build.json`.
>   - Update `eslint-warning-thresholds.json` accordingly.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
61b5206. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Gudahtt

eslint-warning-thresholds.json

@@ -93,9 +93,6 @@
     "jsdoc/tag-lines": 2
   },
   "packages/base-controller/src/BaseController.test.ts": {
-    "import-x/namespace": 15
-  },
-  "packages/base-controller/src/next/BaseController.test.ts": {
     "import-x/namespace": 13
   },
   "packages/build-utils/src/transforms/remove-fenced-code.test.ts": {

jest.config.packages.js

@@ -80,9 +80,6 @@ module.exports = {
   // Here we ensure that Jest resolves `@metamask/*` imports to the uncompiled source code for packages that live in this repo.
   // NOTE: This must be synchronized with the `paths` option in `tsconfig.packages.json`.
   moduleNameMapper: {
-    '^@metamask/base-controller/next': [
-      '<rootDir>/../base-controller/src/next',
-    ],
     '^@metamask/(.+)$': [
       '<rootDir>/../$1/src',
       // Some @metamask/* packages we are referencing aren't in this monorepo,

packages/account-tree-controller/src/AccountTreeController.test.ts

@@ -9,7 +9,7 @@ import {
   type AccountGroupId,
 } from '@metamask/account-api';
 import type { AccountId } from '@metamask/accounts-controller';
-import { deriveStateFromMetadata } from '@metamask/base-controller/next';
+import { deriveStateFromMetadata } from '@metamask/base-controller';
 import {
   BtcAccountType,
   EthAccountType,

packages/account-tree-controller/src/AccountTreeController.ts

@@ -8,8 +8,8 @@ import type {
 } from '@metamask/account-api';
 import type { MultichainAccountWalletStatus } from '@metamask/account-api';
 import { type AccountId } from '@metamask/accounts-controller';
-import type { StateMetadata } from '@metamask/base-controller/next';
-import { BaseController } from '@metamask/base-controller/next';
+import type { StateMetadata } from '@metamask/base-controller';
+import { BaseController } from '@metamask/base-controller';
 import type { TraceCallback } from '@metamask/controller-utils';
 import { isEvmAccountType } from '@metamask/keyring-api';
 import type { InternalAccount } from '@metamask/keyring-internal-api';

packages/accounts-controller/src/AccountsController.test.ts

@@ -1,4 +1,4 @@
-import { deriveStateFromMetadata } from '@metamask/base-controller/next';
+import { deriveStateFromMetadata } from '@metamask/base-controller';
 import { InfuraNetworkType } from '@metamask/controller-utils';
 import type {
   AccountAssetListUpdatedEventPayload,

packages/accounts-controller/src/AccountsController.ts

@@ -2,7 +2,7 @@ import {
   type ControllerGetStateAction,
   type ControllerStateChangeEvent,
   BaseController,
-} from '@metamask/base-controller/next';
+} from '@metamask/base-controller';
 import {
   type SnapKeyringAccountAssetListUpdatedEvent,
   type SnapKeyringAccountBalancesUpdatedEvent,

packages/address-book-controller/src/AddressBookController.test.ts

@@ -1,4 +1,4 @@
-import { deriveStateFromMetadata } from '@metamask/base-controller/next';
+import { deriveStateFromMetadata } from '@metamask/base-controller';
 import { toHex } from '@metamask/controller-utils';
 import {
   Messenger,

packages/address-book-controller/src/AddressBookController.ts

@@ -1,8 +1,8 @@
 import type {
   ControllerGetStateAction,
   ControllerStateChangeEvent,
-} from '@metamask/base-controller/next';
-import { BaseController } from '@metamask/base-controller/next';
+} from '@metamask/base-controller';
+import { BaseController } from '@metamask/base-controller';
 import {
   normalizeEnsName,
   isValidHexAddress,

packages/announcement-controller/src/AnnouncementController.test.ts

@@ -1,4 +1,4 @@
-import { deriveStateFromMetadata } from '@metamask/base-controller/next';
+import { deriveStateFromMetadata } from '@metamask/base-controller';
 import {
   Messenger,
   MOCK_ANY_NAMESPACE,

packages/announcement-controller/src/AnnouncementController.ts

@@ -2,8 +2,8 @@ import type {
   ControllerGetStateAction,
   ControllerStateChangeEvent,
   StateMetadata,
-} from '@metamask/base-controller/next';
-import { BaseController } from '@metamask/base-controller/next';
+} from '@metamask/base-controller';
+import { BaseController } from '@metamask/base-controller';
 import type { Messenger } from '@metamask/messenger';
 
 type ViewedAnnouncement = {