Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type on OlSourceVector.features #399

Open
azygis opened this issue Dec 17, 2024 · 1 comment · May be fixed by #400
Open

Wrong type on OlSourceVector.features #399

azygis opened this issue Dec 17, 2024 · 1 comment · May be fixed by #400
Labels
bug Something isn't working

Comments

@azygis
Copy link

azygis commented Dec 17, 2024

Describe the bug
The type on features prop of OlSourceVector is wrong (or incomplete). Currently it accepts array / collection of Geometry but it should be Feature or even FeatureLike. This forces us to add nasty hacks like const realFeatures = computed(() => features.value as unknown as Geometry[]); and passing that instead.

Affected version(s)

Pretty sure all version up until now.

To Reproduce
N/A

Expected behavior
Above.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
I can create a pull request with the change but I'm not sure if it will become a breaking change or not. Would like to know if it was an oversight or an intentional implementation.

@azygis azygis added the bug Something isn't working label Dec 17, 2024
@d-koppenhagen
Copy link
Collaborator

Hey, please send me a PR. I will check it and think about if a breaking change is necessary.

@azygis azygis linked a pull request Dec 18, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants