Reject subdomain (#110)

Author: VincentLanglet

src/EmailChecker/EmailChecker.php

@@ -51,6 +51,24 @@ public function isValid(string $email): bool
             return false;
         }
 
-        return !$this->adapter->isThrowawayDomain($domain);
+        foreach ($this->allDomainSuffixes($domain) as $domainSuffix) {
+            if ($this->adapter->isThrowawayDomain($domainSuffix)) {
+                return false;
+            }
+        }
+
+        return true;
+    }
+
+    /**
+     * @return iterable<string>
+     */
+    private function allDomainSuffixes(string $domain): iterable
+    {
+        $components = explode('.', $domain);
+
+        foreach ($components as $i => $_) {
+            yield implode('.', array_slice($components, $i));
+        }
     }
 }

tests/EmailChecker/Tests/EmailCheckerTest.php

@@ -12,39 +12,40 @@
 namespace EmailChecker\Tests;
 
 use EmailChecker\Adapter\AdapterInterface;
+use EmailChecker\Adapter\ArrayAdapter;
 use EmailChecker\EmailChecker;
 
 final class EmailCheckerTest extends TestCase
 {
     public function testEmailIsValid(): void
     {
-        $adapter = $this->createMock(AdapterInterface::class);
-        $adapter
-             ->method('isThrowawayDomain')
-             ->willReturn(false);
-
+        $adapter = new ArrayAdapter([]);
         $checker = new EmailChecker($adapter);
 
         self::assertTrue($checker->isValid('foo@bar.org'));
     }
 
     public function testEmailIsNotValid(): void
     {
-        $adapter = $this->createMock(AdapterInterface::class);
-        $adapter
-             ->method('isThrowawayDomain')
-             ->willReturn(true);
-
+        $adapter = new ArrayAdapter(['bar.org']);
         $checker = new EmailChecker($adapter);
 
         self::assertFalse($checker->isValid('foo@bar.org'));
     }
 
     public function testMalformattedEmail(): void
     {
-        $adapter = $this->createMock(AdapterInterface::class);
+        $adapter = new ArrayAdapter([]);
         $checker = new EmailChecker($adapter);
 
         self::assertFalse($checker->isValid('foo[at]bar.org'));
     }
+
+    public function testSubDomain(): void
+    {
+        $adapter = new ArrayAdapter(['bar.org']);
+        $checker = new EmailChecker($adapter);
+
+        self::assertFalse($checker->isValid('foo@baz.bar.org'));
+    }
 }