perf: remove redundant “stale” check for cache reads as it's handled by timer yielded revalidator

Author: MattCCC

src/cache-manager.ts

@@ -223,20 +223,6 @@ function isCacheExpired(entry: CacheEntry<any>): boolean {
   return timeNow() > entry.expiry;
 }
 
-/**
- * Checks if the cache entry is stale based on its timestamp and the stale time.
- *
- * @param {CacheEntry<any>} entry - The cache entry to check.
- * @returns {boolean} - Returns true if the cache entry is stale, false otherwise.
- */
-function isCacheStale(entry: CacheEntry<any>): boolean {
-  if (!entry.stale) {
-    return false;
-  }
-
-  return timeNow() > entry.stale;
-}
-
 /**
  * Retrieves a cached response from the internal cache using the provided key.
  *
@@ -453,27 +439,15 @@ export function getCachedResponse<
   }
 
   const isExpired = isCacheExpired(entry);
-  const isStale = isCacheStale(entry);
 
   // If completely expired, delete and return null
   if (isExpired) {
     deleteCache(cacheKey);
     return null;
   }
 
-  // If fresh (not stale), return immediately
-  if (!isStale) {
-    return entry.data;
-  }
-
-  // SWR: Data is stale but not expired
-  if (isStale && !isExpired) {
-    // Triggering background revalidation here could cause race conditions
-    // So we return stale data immediately and leave it up to implementers to handle revalidation
-    return entry.data;
-  }
-
-  return null;
+  // Return data whether fresh or stale (SWR: serve stale, revalidation is timer-driven)
+  return entry.data;
 }
 
 /**