Skip to content

Commit 9db442d

Browse files
committed
Added await-thenable rule to prevent unnecessary await, and fixed utils.getRandomBytes
1 parent 673445d commit 9db442d

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.eslintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@
108108
"@typescript-eslint/no-misused-promises": ["error", {
109109
"checksVoidReturn": false
110110
}],
111+
"@typescript-eslint/await-thenable": ["error"],
111112
"@typescript-eslint/naming-convention": [
112113
"error",
113114
{

tests/DBTransaction.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ describe(DBTransaction.name, () => {
652652
await tran.put('f', '6');
653653
await tran.put('j', '10');
654654
await tran.put('k', '11');
655-
const iterator = await tran.iterator();
655+
const iterator = tran.iterator();
656656
iterator.seek('a');
657657
expect(await iterator.next()).toStrictEqual([
658658
Buffer.from('a'),

tests/utils.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,16 @@ const ivSize = 16;
44
const authTagSize = 16;
55

66
async function getRandomBytes(size: number): Promise<Buffer> {
7-
return Buffer.from(await random.getBytes(size), 'binary');
7+
const p = new Promise<string>((resolve, reject) => {
8+
random.getBytes(size, (e, bytes) => {
9+
if (e != null) {
10+
reject(e);
11+
} else {
12+
resolve(bytes);
13+
}
14+
});
15+
});
16+
return Buffer.from(await p, 'binary');
817
}
918

1019
function getRandomBytesSync(size: number): Buffer {

0 commit comments

Comments
 (0)