From d818b8365e1fed1c844eb6a4a4b9566f2d152f93 Mon Sep 17 00:00:00 2001
From: CDeltakai <deltakai2010@gmail.com>
Date: Wed, 14 May 2025 14:06:15 +1000
Subject: [PATCH 1/3] chore: update js-lint to 0.2.6

---
 package-lock.json | 10 +++++-----
 package.json      |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 77f499a..fd48ba6 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -15,7 +15,7 @@
         "@matrixai/timer": "^2.0.0"
       },
       "devDependencies": {
-        "@matrixai/lint": "^0.2.4",
+        "@matrixai/lint": "^0.2.6",
         "@swc/core": "^1.3.76",
         "@swc/jest": "^0.2.29",
         "@types/jest": "^29.5.2",
@@ -2093,9 +2093,9 @@
       }
     },
     "node_modules/@matrixai/lint": {
-      "version": "0.2.4",
-      "resolved": "https://registry.npmjs.org/@matrixai/lint/-/lint-0.2.4.tgz",
-      "integrity": "sha512-LaFiAmTMzGc0IItyJ+VlTE5Hcko0vAn0mXYd19SbNG+ubnLI3NIEEuHwIGJFJ84Y2Zid0/YOG69IrFQHnNmJjw==",
+      "version": "0.2.6",
+      "resolved": "https://registry.npmjs.org/@matrixai/lint/-/lint-0.2.6.tgz",
+      "integrity": "sha512-Cbx6SCTAqSt7lTKkaXL7wB+KbkiXYpQ0LdV5fPcnzEfG0sCuG8dbJcwzgHT5Qn7ubG71BBLUVFjHY1EGADzT8g==",
       "dev": true,
       "license": "Apache-2.0",
       "dependencies": {
@@ -2105,7 +2105,7 @@
         "@typescript-eslint/parser": "^8.27.0",
         "@typescript-eslint/utils": "^8.26.1",
         "commander": "^13.1.0",
-        "eslint": ">=9.0.0",
+        "eslint": "^9.0.0",
         "eslint-config-prettier": "^9.1.0",
         "eslint-plugin-import": "^2.31.0",
         "eslint-plugin-jsx-a11y": "^6.10.2",
diff --git a/package.json b/package.json
index 5c0fce4..c8d4a6a 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
     "@matrixai/timer": "^2.0.0"
   },
   "devDependencies": {
-    "@matrixai/lint": "^0.2.4",
+    "@matrixai/lint": "^0.2.6",
     "@swc/core": "^1.3.76",
     "@swc/jest": "^0.2.29",
     "@types/jest": "^29.5.2",

From d86eceefe7e33e5a52ce58c91ec1c0f28edd06d5 Mon Sep 17 00:00:00 2001
From: CDeltakai <deltakai2010@gmail.com>
Date: Wed, 14 May 2025 15:40:01 +1000
Subject: [PATCH 2/3] fix: removed unreachable conditional branches

---
 src/RWLockReader.ts | 4 ----
 src/RWLockWriter.ts | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/src/RWLockReader.ts b/src/RWLockReader.ts
index 85055af..880f163 100644
--- a/src/RWLockReader.ts
+++ b/src/RWLockReader.ts
@@ -218,8 +218,6 @@ class RWLockReader implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';
@@ -268,8 +266,6 @@ class RWLockReader implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';
diff --git a/src/RWLockWriter.ts b/src/RWLockWriter.ts
index c8d965a..d281cc5 100644
--- a/src/RWLockWriter.ts
+++ b/src/RWLockWriter.ts
@@ -219,8 +219,6 @@ class RWLockWriter implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';
@@ -269,8 +267,6 @@ class RWLockWriter implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';

From e5574614b7fdc3dc241226a6cc83865d67eb49d8 Mon Sep 17 00:00:00 2001
From: CDeltakai <deltakai2010@gmail.com>
Date: Wed, 14 May 2025 16:17:19 +1000
Subject: [PATCH 3/3] fix: ensure waitPs.reverse() explicitly discards the
 returned array with void LockBox and Monitor because we only care about side
 effects

---
 src/LockBox.ts | 2 +-
 src/Monitor.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/LockBox.ts b/src/LockBox.ts
index f287352..cdf2627 100644
--- a/src/LockBox.ts
+++ b/src/LockBox.ts
@@ -235,7 +235,7 @@ class LockBox<L extends Lockable = Lockable> implements Lockable {
         signal.addEventListener(
           'abort',
           () => {
-            waitPs.reverse();
+            void waitPs.reverse();
             for (const waitP of waitPs) {
               waitP.cancel(signal.reason);
             }
diff --git a/src/Monitor.ts b/src/Monitor.ts
index 6d05bbf..2ff2488 100644
--- a/src/Monitor.ts
+++ b/src/Monitor.ts
@@ -310,7 +310,7 @@ class Monitor<RWLock extends RWLockReader | RWLockWriter> implements Lockable {
         signal.addEventListener(
           'abort',
           () => {
-            waitPs.reverse();
+            void waitPs.reverse();
             for (const waitP of waitPs) {
               waitP.cancel(signal.reason);
             }