Skip to content

Windows Integration Script doesn't fail even if underlying executable fails #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CMCDragonkai opened this issue May 21, 2022 · 6 comments
Closed

Windows Integration Script doesn't fail even if underlying executable fails #43

CMCDragonkai opened this issue May 21, 2022 · 6 comments
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@CMCDragonkai
Copy link
Member

Specification

Fix the windows integration job script that doesn't fail even when the underlying executable fails .

Additional context

Tasks

  1. ...
  2. ...
  3. ...
@CMCDragonkai CMCDragonkai added the development Standard development label May 21, 2022
@CMCDragonkai
Copy link
Member Author

Too bad powershell doesn't make this easy: https://stackoverflow.com/questions/48864988/powershell-with-git-command-error-handling-automatically-abort-on-non-zero-exi/48877892#48877892

@CMCDragonkai
Copy link
Member Author

We can use that function there to check if the command executed properly.

@CMCDragonkai
Copy link
Member Author

May require sourcing that into the powershell.

@CMCDragonkai
Copy link
Member Author

CMCDragonkai commented Jul 19, 2022 •
edited
Loading

We may install something like: https://github.com/mklement0/Native and use iee.

@CMCDragonkai
Copy link
Member Author

@tegefaulkes this will be required for any windows integration tests.

@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Jul 10, 2023
@CMCDragonkai
Copy link
Member Author

Not relevant anymore. Will later be investigated under Polykey-CLI.

@CMCDragonkai CMCDragonkai closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CMCDragonkai