Add Parity and Blocking Read support #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid, that the source code has to be modified, when more than 64 devices shall be supported, the corresponding defines (COM_MAXDEVICES) can be optionally set in the makefile now. This is especially important on WSL (Windows Subsystem for Linux), which installs 192 serial devices, no matter if there is a real hardware counterpart on the windows side.
The Linuxversion defined __USE_MISC without checking if it was already defined in one of the headers. This might result in compiler warnings. Furthermore the Windowsversion passed size_t types to uint32_t, which caused compiler warnings on MSVC 64bit
If the corresponding macros are available from the OS up to 4MBit are now supported.
the comReadBlocking() allows to specify a timeout. It will wait until 'len' bytes are read or 'timeout' expired.
Now also Parity Bits like ODD and EVEN can be enforced.
During Refactoring conditional defines for macOS were removed accidentially.
In contrary to Windows Linux had XON/XOFF activated, which caused swallowing of the characters 0x11 (input) and 0x13 (output).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this extensions the library supports parity checking und blocking reads.
Furthermore some minor additions were added.