Fixed failing tests

Author: david-yz-liu

app/controllers/api/roles_controller.rb

@@ -137,15 +137,15 @@ def create_role
 
     def update_role(role)
       ApplicationRecord.transaction do
-        if params[:section_name]
-          if params[:section_name].empty?
+        if params.key?(:section_name)
+          if params[:section_name].blank?
             role.section = nil
           else
             role.section = @current_course.sections.find_by!(name: params[:section_name])
           end
         end
-        role.grace_credits = params[:grace_credits] if params[:grace_credits]
-        role.hidden = params[:hidden].to_s.casecmp('true').zero? if params[:hidden]
+        role.grace_credits = params[:grace_credits] if params.key?(:grace_credits)
+        role.hidden = params[:hidden].to_s.casecmp('true').zero? if params.key?(:hidden)
         role.save!
       end
       render 'shared/http_status', locals: { code: '200', message:

app/controllers/graders_controller.rb

@@ -136,7 +136,6 @@ def global_actions
         if found_empty_submission
           assign_all_graders(filtered_grouping_ids, grader_ids)
           flash_now(:info, I18n.t('graders.group_submission_no_files'))
-          head :ok
         else
           assign_all_graders(grouping_ids, grader_ids)
         end
@@ -192,6 +191,7 @@ def global_actions
         rescue StandardError => e
           head :bad_request
           flash_now(:error, e.message)
+          return
         end
       end
     when 'criteria_table'