MDEV-14432 mysqldump does not preserve case of table names in generated sql

MohanadKh03 · vuvova · commit ddd5ba3a00eb · 2025-04-24T18:10:09.000+02:00
inside the get_lookup_field_values when lower_case_table_names's value
is 2 this should reserve the case for the table's and database's names
so this commit changes the condition to lowercase only when the
lower_case_table_name's value is 1 not just 1 and 2 "any value not equal
0"
diff --git a/mysql-test/main/lowercase_table2.result b/mysql-test/main/lowercase_table2.result
@@ -185,7 +185,7 @@ create table myUC (i int);
 select TABLE_SCHEMA,TABLE_NAME FROM information_schema.TABLES
 where TABLE_SCHEMA ='mysqltest_LC2';
 TABLE_SCHEMA	TABLE_NAME
-mysqltest_lc2	myUC
+mysqltest_LC2	myUC
 use test;
 drop database mysqltest_LC2;
 #
diff --git a/sql/sql_show.cc b/sql/sql_show.cc
@@ -4348,7 +4348,7 @@ bool get_lookup_field_values(THD *thd, COND *cond, bool fix_table_name_case,
     break;
   }
 
-  if (lower_case_table_names && !rc)
+  if (lower_case_table_names == 1 && !rc)
   {
     /* 
       We can safely do in-place upgrades here since all of the above cases

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ create table myUC (i int);`
`185`	`185`	`select TABLE_SCHEMA,TABLE_NAME FROM information_schema.TABLES`
`186`	`186`	`where TABLE_SCHEMA ='mysqltest_LC2';`
`187`	`187`	`TABLE_SCHEMA TABLE_NAME`
`188`		`-mysqltest_lc2 myUC`
	`188`	`+mysqltest_LC2 myUC`
`189`	`189`	`use test;`
`190`	`190`	`drop database mysqltest_LC2;`
`191`	`191`	`#`
Original file line number	Diff line number	Diff line change
`@@ -4348,7 +4348,7 @@ bool get_lookup_field_values(THD thd, COND cond, bool fix_table_name_case,`
`4348`	`4348`	`break;`
`4349`	`4349`	`}`
`4350`	`4350`
`4351`		`- if (lower_case_table_names && !rc)`
	`4351`	`+ if (lower_case_table_names == 1 && !rc)`
`4352`	`4352`	`{`
`4353`	`4353`	`/*`
`4354`	`4354`	`We can safely do in-place upgrades here since all of the above cases`