wordpress: restructure trigger

An amd64 parent builder isn't sufficient grounds for triggering the manifest build.
All parent builders must have completed for the docker library to generate the manifest
used to trigger the wordpress build.

To do this the generation of the lasttag occurs on even non-production builders.
The s_wordpress is triggered on a not-null lasttag.

Properties and tests for the MariaDB operator test occur when the push_containers
property is true (prod), so omit those directly in the dev environment, but also
if lasttag fails.

Author: grooverdan

master-nonlatent/master.cfg

@@ -717,21 +717,6 @@ f_dockerlibrary.addStep(
         ],
     )
 )
-f_dockerlibrary.addStep(
-    steps.Trigger(
-        name="WordPress",
-        schedulerNames=["s_wordpress"],
-        waitForFinish=False,
-        updateSourceStamp=False,
-        set_properties={
-            "tarbuildnum": Property("tarbuildnum"),
-            "ubi": Property("ubi"),
-        },
-        doStepIf=lambda step: str(step.getProperty("parentbuildername")).startswith(
-            "amd64"
-        ),
-    )
-)
 f_dockerlibrary.addStep(
     steps.ShellCommand(
         name="build quay.io manifest image for MariaDB",
@@ -755,6 +740,19 @@ f_dockerlibrary.addStep(
         property="lasttag",
     )
 )
+f_dockerlibrary.addStep(
+    steps.Trigger(
+        name="WordPress",
+        schedulerNames=["s_wordpress"],
+        waitForFinish=False,
+        updateSourceStamp=False,
+        set_properties={
+            "tarbuildnum": Property("tarbuildnum"),
+            "ubi": Property("ubi"),
+        },
+        doStepIf=lambda step: (str(step.getProperty("lasttag")) != ""),
+    )
+)
 f_dockerlibrary.addStep(
     steps.SetPropertyFromCommand(
         name="Determine sha for the last tag",
@@ -766,7 +764,10 @@ f_dockerlibrary.addStep(
             ),
         ],
         property="lastsha",
-        doStepIf=lambda step: (str(step.getProperty("lasttag")) != ""),
+        doStepIf=lambda step: (
+            step.getProperty("push_containers")
+            and str(step.getProperty("lasttag")) != ""
+        ),
     )
 )
 f_dockerlibrary.addStep(
@@ -778,7 +779,9 @@ f_dockerlibrary.addStep(
             "gh auth login --with-token < ~/gh_auth",
         ],
         doStepIf=lambda step: (
-            str(step.getProperty("lastsha")) != "null" and step.hasProperty("lastsha")
+            step.getProperty("push_containers")
+            and str(step.getProperty("lastsha")) != "null"
+            and step.hasProperty("lastsha")
         ),
     )
 )
@@ -797,7 +800,9 @@ f_dockerlibrary.addStep(
             ),
         ],
         doStepIf=lambda step: (
-            str(step.getProperty("lastsha")) != "null" and step.hasProperty("lastsha")
+            step.getProperty("push_containers")
+            and str(step.getProperty("lastsha")) != "null"
+            and step.hasProperty("lastsha")
         ),
     )
 )

scripts/docker-library-manifest.sh

@@ -108,10 +108,9 @@ trap 'manifest_image_cleanup "$devmanifest" "$t"' EXIT
 
 if [ "$prod_environment" = "True" ]; then
   buildah manifest push --all "$devmanifest" "docker://quay.io/mariadb-foundation/mariadb-devel:${container_tag}"
-  echo "${container_tag}" > last_tag
-else
-  rm -f last_tag
 fi
+# Still want last_tag in dev environment to trigger wordpress build.
+echo "${container_tag}" > last_tag
 
 #
 # MAKE Debug manifest