MDBF-1142 Hide worker / build prioritization from user-facing settings

Worker selection (canStartBuild)
and queue prioritization by branch (nextBuild) should not concern the user.

These are considered internal mechanisms, and allowing users to modify them
when configuring a builder could lead to unexpected behavior in the master.

Author: RazvanLiviuVarzaru

configuration/builders/base.py

@@ -6,6 +6,7 @@
 from buildbot.process.buildrequest import BuildRequest
 from buildbot.process.factory import BuildFactory
 from buildbot.process.workerforbuilder import AbstractWorkerForBuilder
+from configuration.builders.callables import canStartBuild, nextBuild
 from configuration.builders.infra.runtime import BuildSequence
 from configuration.steps.processors import (
     processor_docker_cleanup,
@@ -101,11 +102,7 @@ def get_factory(self) -> BuildFactory:
     def get_config(
         self,
         workers: Iterable[WorkerBase],
-        can_start_build: Callable[
-            [Builder, AbstractWorkerForBuilder, BuildRequest], bool
-        ],
         jobs: int,
-        next_build: Callable[[Builder, Iterable[BuildRequest]], BuildRequest],
         tags: list[str] = [],
         properties: dict[str, str] = None,
     ) -> util.BuilderConfig:
@@ -118,7 +115,6 @@ def get_config(
             can_start_build (Callable): A callable that determines if a build can
                 start on a worker.
             jobs (int): The number of CPU's to allocate for commands that support parallel execution.
-            next_build (Callable): A callable that determines the next build request.
             tags (list[str], optional): A list of tags associated with the builder.
                 Defaults to an empty list.
             properties (dict[str, str], optional): Additional properties for the builder.
@@ -127,7 +123,6 @@ def get_config(
             - jobs is a measure of how many CPU's are used for the build, for commands that support parallel execution (e.g. make, mtr).
             - provide a value greater or equal to 1
             - jobs should never exceed the number of CPU's available on the worker, given by the worker total_jobs property.
-            - canStartBuild will determine at runtime if the builder can start on any of the workers assigned to it, based on what other jobs were claimed (currently running) by other builders.
         Returns:
             util.BuilderConfig: A BuilderConfig object containing the builder's configuration.
         """
@@ -145,8 +140,8 @@ def get_config(
             name=self.name,
             workernames=[worker.name for worker in workers],
             tags=tags,
-            nextBuild=next_build,
-            canStartBuild=can_start_build,
+            nextBuild=nextBuild,
+            canStartBuild=canStartBuild,
             factory=self.get_factory(),
             properties=properties,
         )

configuration/builders/common.py

@@ -3,7 +3,6 @@
 from typing import Union
 
 from configuration.builders.base import GenericBuilder
-from configuration.builders.callables import canStartBuild, nextBuild
 from configuration.builders.infra.runtime import DockerConfig
 from configuration.builders.sequences.release import deb_autobake, rpm_autobake
 
@@ -72,8 +71,6 @@ def deb_release_builder(
         ],
     ).get_config(
         workers=worker_pool,
-        next_build=nextBuild,
-        can_start_build=canStartBuild,
         tags=["release_packages", "autobake", "deb"],
         jobs=DEFAULT_BUILDER_JOBS,
         properties={
@@ -127,8 +124,6 @@ def rpm_release_builder(
         ],
     ).get_config(
         workers=worker_pool,
-        next_build=nextBuild,
-        can_start_build=canStartBuild,
         tags=["release_packages", "autobake", "rpm"],
         jobs=DEFAULT_BUILDER_JOBS,
         properties={

master-migration/master.cfg

@@ -6,7 +6,6 @@ import os
 import yaml
 
 from configuration.builders.base import GenericBuilder
-from configuration.builders.callables import canStartBuild, nextBuild
 from configuration.builders.common import (
     deb_release_builder,
     docker_config,
@@ -109,8 +108,6 @@ c["builders"].extend(
             ],
         ).get_config(
             workers=DEFAULT_AMD64_WORKER_POOL,
-            next_build=nextBuild,
-            can_start_build=canStartBuild,
             tags=["compile-only", "protected"],
             jobs=compile_only_jobs,
         )
@@ -134,8 +131,6 @@ c["builders"].append(
         ],
     ).get_config(
         workers=DEFAULT_AMD64_WORKER_POOL,
-        next_build=nextBuild,
-        can_start_build=canStartBuild,
         tags=[
             "debug",
         ],
@@ -165,8 +160,6 @@ def ubasan_builder(name: str, debug: bool) -> GenericBuilder:
         ],
     ).get_config(
         workers=DEFAULT_AMD64_WORKER_POOL,
-        next_build=nextBuild,
-        can_start_build=canStartBuild,
         tags=list(tags_ubasan),
         jobs=jobs,
     )
@@ -194,8 +187,6 @@ def msan_builder(name: str, debug: bool) -> GenericBuilder:
         ],
     ).get_config(
         workers=DEFAULT_AMD64_WORKER_POOL,
-        next_build=nextBuild,
-        can_start_build=canStartBuild,
         tags=list(tags_msan),
         jobs=jobs,
     )