Skip to content

Commit 41a29fa

Browse files
cvicentiuRazvanLiviuVarzaru
authored andcommitted
MDBF-961: Fixup master-refactor windows save packages
Stray comma (,) split a single string into two arguments for util.Interpolate Unify both f_windows_msi and f_windows to use a single function call.
1 parent 04922d2 commit 41a29fa

File tree

1 file changed

+10
-31
lines changed

1 file changed

+10
-31
lines changed

master-nonlatent/master.cfg

Lines changed: 10 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -250,23 +250,23 @@ for typ in windows_tests:
250250
)
251251

252252

253-
f_windows.addStep(
254-
steps.DirectoryUpload(
253+
def windows_save_logs_step():
254+
return steps.DirectoryUpload(
255255
name="save mariadb log files",
256256
alwaysRun=True,
257257
workersrc="buildbot\\logs\\",
258258
masterdest=util.Interpolate(
259259
"/srv/buildbot/packages/"
260-
+ "%(prop:tarbuildnum)s"
261-
+ "/logs/"
262-
+ "%(prop:buildername)s"
260+
+ "%(prop:tarbuildnum)s/logs/%(prop:buildername)s"
263261
),
264262
url=util.Interpolate(
265-
os.environ["ARTIFACTS_URL"],
266-
"/" "%(prop:tarbuildnum)s" "/" "logs" "/" "%(prop:buildername)s" "/",
263+
os.environ["ARTIFACTS_URL"]
264+
+ "/%(prop:tarbuildnum)s/logs/%(prop:buildername)s/",
267265
),
268266
)
269-
)
267+
268+
269+
f_windows.addStep(windows_save_logs_step())
270270
f_windows.addStep(
271271
steps.ShellCommand(
272272
name="cleanup",
@@ -438,29 +438,8 @@ for typ in windows_msi_tests:
438438
create_scripts=windows_msi_tests[typ].get("create_scripts", False),
439439
)
440440

441-
f_windows_msi.addStep(
442-
steps.DirectoryUpload(
443-
name="save mariadb log files",
444-
alwaysRun=True,
445-
workersrc="buildbot\\logs\\",
446-
masterdest=util.Interpolate(
447-
"/srv/buildbot/packages/"
448-
+ "%(prop:tarbuildnum)s"
449-
+ "/logs/"
450-
+ "%(prop:buildername)s"
451-
),
452-
url=util.Interpolate(
453-
f'{os.environ["ARTIFACTS_URL"]}'
454-
"/"
455-
"%(prop:tarbuildnum)s"
456-
"/"
457-
"logs"
458-
"/"
459-
"%(prop:buildername)s"
460-
"/"
461-
),
462-
)
463-
)
441+
f_windows_msi.addStep(windows_save_logs_step())
442+
464443
# create package and upload to master
465444
f_windows_msi.addStep(steps.ShellCommand(command='dojob "dir"'))
466445
f_windows_msi.addStep(

0 commit comments

Comments
 (0)