appearence.opacity affects quick settings buttons (and more)

[lwestlund]

Configuring appearence.opacity = 0.0 to get for example transparent islands results in that the quick settings buttons also become transparent, which is probably not what most want.

Compare opacity 1.0 and 0.0:

My suggestion is to add separate configuration for this, which would affect

1. The buttons on the left and right of the sliders, and the power button

   ashell/src/theme.rs

   Line 272 in 2600187

   let opacity = self.opacity;

2. The quick settings button (whole button for wi-fi, bluetooth, etc)

   ashell/src/theme.rs

   Line 475 in 2600187

   let opacity = self.opacity;

3. The quick settings submenu button (visible only when hovering the little ">" on a quick setting)

   ashell/src/theme.rs

   Line 435 in 2600187

   let opacity = self.opacity;

4. The module button (visible only when hovering for example the quick settings module in the bar)

   ashell/src/theme.rs

   Line 657 in 2600187

   let opacity = self.opacity;

I'm assuming that it would be enough to get started by just adding a "button" opacity that applies to these four.

On top of those it's probably also relevant to look into opacity of the tempo/weather module at

ashell/src/modules/tempo/weather.rs

Lines 24 to 25 in 2600187

	let (space, font_size, opacity, radius) =
	use_theme(|t| (t.space, t.font_size, t.opacity, t.radius));

because that is also changing a bit unexpectedly with opacity 0.0. I suppose that this could also be a separate config, but I'm a bit too new to this code base to say how to deal with it in a nice way.

Again, opacity 1.0 and 0.0

[romanstingler]

@MalpenZibo

[MalpenZibo]

If I can travel back in time, I would like to punch myself in the face the day that I decided to add the opacity settings XD

The point is that the opacity settings work globally on the entire bar for each background color. The only difference between those settings and setting the opacity level for the layer in the compositor settings is that the foreground color is not affected.

That said. It's a feature that I don't use, and it's very easy to make a mistake handlign that settings in the codebase. The behavior is somewhat correct. The point is that setting the opacity to 0 makes the entire bar transparent (or at least it should) with the exception of the foreground color. It's not possible to obtain what you want with that setting right now.

We could probably refactor that part. I already have in the roadmap the implementation of the [ext_background_effect_manager_v1](https://wayland.app/protocols/ext-background-effect-v1#ext_background_effect_manager_v1) so it could make sense to also check this part.

[lwestlund]

Yes unfortunately not all decisions we make are good decisions 😄

I see, and maybe it's also part me not understanding the intent of the config. My goal was to have transparent islands, and while I'm fine maintaining my own tiny fork with only that change, I was interested in hearing your thoughts on it and see if there was any way I could help out if it was relevant for upstreaming. So yeah, let me know!