Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card doesn't support new weather entitles without forecast attributes #102

Open
2 tasks done
Scoop2389 opened this issue Oct 13, 2023 · 14 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@Scoop2389
Copy link

Additional Information:
@Makin-Things, look I'm sorry. I didn't mean to come off as rude or disrespectful to you or anyone who contributed to your project. I was trying to do my due diligence by requesting a card I thought was broken and unmaintained to be removed from HACS. I thought that all weather integrations were updated to this new standard, and that meant that this card would be broken for everyone. I didn't realize that a lot of use cases and weather integrations haven't been updated yet and I didn't know what that request meant to you guys. I really do appreciate the functionality of this card and would love to help reproduce this and provide any logs you need.
Sincerely, let's try again and try to solve this together. Thanks.

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser

Release with the issue:
Card Version: 1.0.5
Home Assistant Core: 2023.9

Last working release (if known):
Card Version: 1.0.5
Home Assistant Core: 2023.8.4

Browser and Operating System:
Windows, Edge, Chrome + Android, Home Assistant Mobile App

Description of problem:
In Home Assistant Core 2023.9, a new weather forecast scheme was introduced in which entities no longer have forecast attributes, and instead forecast data must be retrieved by calling a service (weather.get_forecast) (Ref). This card does not call the service, and therefore entities without forecast attributes do not appear in this card.

Javascript errors shown in the web inspector (if applicable):

platinum-weather-card-df6d26e2.js:41  Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'filter')
    at ge._getForecastPropFromWeather (platinum-weather-card-df6d26e2.js:268:71)
    at ge._checkForErrors (platinum-weather-card-df6d26e2.js:73:17788)
    at ge.render (platinum-weather-card-df6d26e2.js:268:1014)
    at ge.update (platinum-weather-card-df6d26e2.js:47:547)
    at ge.performUpdate (platinum-weather-card-df6d26e2.js:41:5079)
    at ge.scheduleUpdate (platinum-weather-card-df6d26e2.js:41:4726)
    at ge._$EC (platinum-weather-card-df6d26e2.js:41:4634)
@Scoop2389 Scoop2389 added the bug Something isn't working label Oct 13, 2023
@tommyjlong
Copy link

I too would love to see this card support the new forecast subscription methods! :)

I have a custom weather integration that I have been re-doing to support this new method, so would luv to have this card support it as I currently use this card with my current custom weather integration.

I don't know javascript, but I have been looking at the hui-weather-forecast card to maybe see what it has done to support the new method.

@DavidFW1960
Copy link
Collaborator

I'm sure Simon will get to this in due course. His real time job is taking all his time at the moment and then some. It's worth noting it's only recently the card was amended to even allow you to use weather entities.
I'd suggest for the time being using template sensors to extract the data from the weather entity and configuring the card for those sensors. That will work perfectly.

@Scoop2389
Copy link
Author

That's totally fine, and I respect his work and hope he gets a chance to work on it whenever he can.

@MadMacMad
Copy link

well... to be honest...
don't think we see a update soon...
i'll already heard he is busy last 2 years...
i'll personally moved to another...
this card doesn't work with:
Openweathermap
DWD
or any other that followed the standard and updated.

@DaN66O
Copy link

DaN66O commented Nov 24, 2023

i'll personally moved to another...

Which other card supports forecast ?

@kaijk
Copy link

kaijk commented Nov 28, 2023

As long as I can supply my own sensor data for all the fields, I'm OK. I get data from the Openweather REST API and roll my own sensors.

@Scoop2389
Copy link
Author

Yeah, the only thing that doesn't work is the forecast

@Tillsy
Copy link

Tillsy commented Dec 23, 2023

Is there anyone that could fork this project and take it over?

@dugite-code
Copy link

@Tillsy there are several forks already that appear to be doing their own thing with this card. this one appears to have some good explanations throughout the readme regarding the differences needed to make it work. Disclaimer I haven't tried any of the forks myself.

@tommyjlong
Copy link

this one appears to have some good explanations throughout the readme regarding the differences needed to make it work. Disclaimer I haven't tried any of the forks myself.

Although I don't program in Javascript, nor Typescript, I did manage to figure out how to get the new HA method for forecast data working on this card, plus a couple of other things here and there. Its working for my purposes, and its possible I may have broke other things along the way, but I don't plan on maintaining it.

Anyway, anyone is welcome to take a look at it for reference (or even use it). I hope Simon gets some free time to get this going again, as this card is really an awesome piece of work 🥇 !!

@Scoop2389
Copy link
Author

Thanks for your fork! I have just began using it and it is pretty awesome and I haven't come across anything broken yet 😁

@majkers
Copy link

majkers commented Apr 26, 2024

@tommyjlong can you please share your template sensors form home assistant to make it work? I am still getting errors like:
'entity_forecast_icon_1=sensor.old_forecast_style_weather' value needs to have a number

@tommyjlong
Copy link

@tommyjlong can you please share your template sensors form home assistant to make it work? I am still getting errors like: 'entity_forecast_icon_1=sensor.old_forecast_style_weather' value needs to have a number

@majkers, I don't use template sensors anymore, but you can take a look at this to see if it helps.

@Scoop2389
Copy link
Author

I personally moved away from this card in favor for this fork which works with the new format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants