Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for Makie 0.20.0 compatibility #184

Closed
pbouffard opened this issue Nov 27, 2023 · 6 comments
Closed

Release for Makie 0.20.0 compatibility #184

pbouffard opened this issue Nov 27, 2023 · 6 comments

Comments

@pbouffard
Copy link

Is a release being worked? Not sure to what extent the breaking changes therein will impact GeoMakie but at minimum a compat update is needed to allow projects which have GeoMakie to using Makie 0.20.0 (without dev or add on a branch of course).

I'm not really familiar with GeoMakie but would be happy to lend a hand with the update if help is needed.
@SimonDanisch
Copy link
Member

I'm working on: #163
But running out of time... It'd be great to get some help to fix get this merged!
Otherwise, the upgrade to 0.20 could be as simple as updating the project.toml

@briochemc
Copy link

Otherwise, the upgrade to 0.20 could be as simple as updating the project.toml

@SimonDanisch Isn't that #183?

@felixcremer
Copy link

I ran the tests for GeoMakie with Makie 0.20 and got the following errors and warnings:
I don't have time to dig into it further at the moment.

     Testing Running tests...
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: Could not find font regular, using TeX Gyre Heros Makie
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/conversions.jl:1138
┌ Warning: `shading = false` is not valid. Use `automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/lighting.jl:243
Running axis_config
Include: ┌ Warning: Found `resolution` in the theme when creating a `Scene`. The `resolution` keyword for `Scene`s and `Figure`s has been deprecated. Use `Figure(; size = ...` or `Scene(; size = ...)` instead, which better reflects that this is a unitless size and not a pixel resolution. The key could also come from `set_theme!` calls or related theming functions.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/scenes.jl:220
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
  1.137646 seconds (1.70 M allocations: 129.912 MiB, 3.90% gc time, 84.43% compilation time)
PNG:       0.542233 seconds (544.47 k allocations: 48.519 MiB, 4.54% gc time, 70.95% compilation time)
PDF:       0.720884 seconds (856.73 k allocations: 56.106 MiB, 5.49% gc time, 95.91% compilation time)
Running basic
Include: ┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `shading = false` is not valid. Use `automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/lighting.jl:243
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
  0.358275 seconds (951.28 k allocations: 59.103 MiB, 4.59% gc time, 81.58% compilation time)
PNG:       0.150081 seconds (89.67 k allocations: 9.774 MiB, 42.74% compilation time)
PDF:       0.102595 seconds (94.61 k allocations: 5.839 MiB, 39.54% compilation time)
Running contourf
Include: ┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `shading = false` is not valid. Use `automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/lighting.jl:243
  3.209115 seconds (6.39 M allocations: 397.629 MiB, 4.91% gc time, 97.19% compilation time: <1% of which was recompilation)
PNG:       0.214872 seconds (334.76 k allocations: 22.191 MiB, 7.41% gc time, 70.94% compilation time)
PDF:       0.109749 seconds (100.17 k allocations: 6.270 MiB, 56.84% compilation time)
Running field_and_countries
Include: ┌ Warning: Found `resolution` in the theme when creating a `Scene`. The `resolution` keyword for `Scene`s and `Figure`s has been deprecated. Use `Figure(; size = ...` or `Scene(; size = ...)` instead, which better reflects that this is a unitless size and not a pixel resolution. The key could also come from `set_theme!` calls or related theming functions.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/scenes.jl:220
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `shading = false` is not valid. Use `automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/lighting.jl:243
  6.322971 seconds (12.80 M allocations: 788.728 MiB, 5.09% gc time, 90.10% compilation time)
PNG:       2.410510 seconds (4.85 M allocations: 303.010 MiB, 5.23% gc time, 56.22% compilation time)
PDF:       2.517064 seconds (3.80 M allocations: 343.857 MiB, 3.30% gc time, 14.98% compilation time)
Running orthographic
Include: orthographic: Error During Test at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40
  Test threw exception
  Expression: begin
    print(rpad("Include: ", 9))
    #= /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:42 =# @time include(filename)
    true
end
  LoadError: AssertionError: vmin != vmax
  Stacktrace:
    [1] locateticks(vmin::Float32, vmax::Float32, n_ideal::Int64, _integer::Bool, _min_n_ticks::Int64)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/ticklocators/linear.jl:79
    [2] locateticks
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/ticklocators/linear.jl:77 [inlined]
    [3] get_tickvalues
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:647 [inlined]
    [4] get_tickvalues
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:565 [inlined]
    [5] get_ticks(ticks::LinearTicks, scale::Function, formatter::Function, vmin::Float32, vmax::Float32)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:553
    [6] (::Makie.var"#1513#1527")(::Tuple{Float32, Tuple{Float32, Float32}, Bool}, limits::Tuple{Float32, Float32}, ticks::LinearTicks, tickformat::Function, scale::Function)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:422
    [7] invokelatest(::Any, ::Any, ::Vararg{Any}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
      @ Base ./essentials.jl:819
    [8] invokelatest(::Any, ::Any, ::Vararg{Any})
      @ Base ./essentials.jl:816
    [9] (::Observables.MapCallback)(value::Any)
      @ Observables ~/.julia/packages/Observables/YdEbO/src/Observables.jl:436
   [10] #map!#179
      @ ~/.julia/packages/Makie/pCA2E/src/scenes.jl:153 [inlined]
   [11] map!
      @ ~/.julia/packages/Makie/pCA2E/src/scenes.jl:146 [inlined]
   [12] Makie.LineAxis(parent::Scene, attrs::Attributes)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:419
   [13] Makie.LineAxis(parent::Scene; kwargs::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}})
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:8
   [14] LineAxis
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:6 [inlined]
   [15] initialize_block!(ax::Axis; palette::Nothing)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks/axis.jl:321
   [16] initialize_block!(ax::Axis)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks/axis.jl:160
   [17] _block(T::Type{Axis}, fig_or_scene::Figure, args::Vector{Any}, kwdict::Dict{Symbol, Any}, bbox::Nothing; kwdict_complete::Bool)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:388
   [18] _block
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:308 [inlined]
   [19] #_block#1341
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:276 [inlined]
   [20] _block(::Type{Axis}, ::GridPosition; kwargs::Base.Pairs{Symbol, Any, NTuple{10, Symbol}, NamedTuple{(:aspect, :xtickformat, :ytickformat, :xticks, :yticks, :limits, :xticklabelpad, :yticklabelpad, :alignmode, :title), Tuple{DataAspect, typeof(GeoMakie.longitude_format), typeof(GeoMakie.latitude_format), LinearTicks, LinearTicks, Tuple{Tuple{Float64, Float64}, Tuple{Int64, Int64}}, Float64, Float64, Outside, String}}})
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:270
   [21] _block
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:263 [inlined]
   [22] #_#1339
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:254 [inlined]
   [23] Block
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:253 [inlined]
   [24] GeoAxis(args::GridPosition; source::String, dest::String, transformation::Proj.Transformation, lonlims::MakieCore.Automatic, latlims::Tuple{Int64, Int64}, coastlines::Bool, coastline_attributes::NamedTuple{(:label,), Tuple{String}}, line_density::Int64, remove_overlapping_ticks::Bool, xtickformat::typeof(GeoMakie.longitude_format), ytickformat::typeof(GeoMakie.latitude_format), xticks::LinearTicks, yticks::LinearTicks, xticklabelpad::Float64, yticklabelpad::Float64, alignmode::Outside, kw::Base.Pairs{Symbol, String, Tuple{Symbol}, NamedTuple{(:title,), Tuple{String}}})
      @ GeoMakie ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/src/geoaxis.jl:105
   [25] top-level scope
      @ ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/examples/orthographic.jl:11
   [26] include
      @ ./client.jl:478 [inlined]
   [27] macro expansion
      @ ./timing.jl:273 [inlined]
   [28] macro expansion
      @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:478 [inlined]
   [29] macro expansion
      @ ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40 [inlined]
   [30] macro expansion
      @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
   [31] (::var"#5#8"{Vector{String}})()
      @ Main ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40
  in expression starting at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/examples/orthographic.jl:11
PNG:       0.058928 seconds (329 allocations: 4.137 MiB, 33.72% gc time)
PDF:       0.000918 seconds (361 allocations: 18.367 KiB)
orthographic: Test Failed at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:52
  Expression: begin
    savepath = "$(example_name).pdf"
    print(rpad("PDF: ", 9))
    #= /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:55 =# @time CairoMakie.save(savepath, Makie.current_figure())
    isfile(savepath) && filesize(savepath) > 1000
end

Stacktrace:
 [1] macro expansion
   @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:478 [inlined]
 [2] macro expansion
   @ ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:52 [inlined]
 [3] macro expansion
   @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
 [4] (::var"#5#8"{Vector{String}})()
   @ Main ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40
Running projections
Include: ┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
┌ Warning: `shading = false` is not valid. Use `automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/lighting.jl:243
┌ Warning: `shading = false` is not valid. Use `automatic`, `NoShading`, `FastShading` or `MultiLightShading`. Defaulting to `NoShading`.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/lighting.jl:243
  0.325964 seconds (526.08 k allocations: 45.254 MiB, 5.55% gc time, 70.70% compilation time)
PNG:       0.981721 seconds (4.95 M allocations: 273.057 MiB, 7.35% gc time)
PDF:       1.259913 seconds (4.95 M allocations: 275.078 MiB, 3.89% gc time)
Running rotating_earth
Include: rotating_earth: Error During Test at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40
  Test threw exception
  Expression: begin
    print(rpad("Include: ", 9))
    #= /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:42 =# @time include(filename)
    true
end
  LoadError: AssertionError: vmin != vmax
  Stacktrace:
    [1] locateticks(vmin::Float32, vmax::Float32, n_ideal::Int64, _integer::Bool, _min_n_ticks::Int64)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/ticklocators/linear.jl:79
    [2] locateticks
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/ticklocators/linear.jl:77 [inlined]
    [3] get_tickvalues
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:647 [inlined]
    [4] get_tickvalues
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:565 [inlined]
    [5] get_ticks(ticks::LinearTicks, scale::Function, formatter::Function, vmin::Float32, vmax::Float32)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:553
    [6] (::Makie.var"#1513#1527")(::Tuple{Float32, Tuple{Float32, Float32}, Bool}, limits::Tuple{Float32, Float32}, ticks::LinearTicks, tickformat::Function, scale::Function)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:422
    [7] invokelatest(::Any, ::Any, ::Vararg{Any}; kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
      @ Base ./essentials.jl:819
    [8] invokelatest(::Any, ::Any, ::Vararg{Any})
      @ Base ./essentials.jl:816
    [9] (::Observables.MapCallback)(value::Any)
      @ Observables ~/.julia/packages/Observables/YdEbO/src/Observables.jl:436
   [10] #map!#179
      @ ~/.julia/packages/Makie/pCA2E/src/scenes.jl:153 [inlined]
   [11] map!
      @ ~/.julia/packages/Makie/pCA2E/src/scenes.jl:146 [inlined]
   [12] Makie.LineAxis(parent::Scene, attrs::Attributes)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:419
   [13] Makie.LineAxis(parent::Scene; kwargs::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}})
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:8
   [14] LineAxis
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/lineaxis.jl:6 [inlined]
   [15] initialize_block!(ax::Axis; palette::Nothing)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks/axis.jl:321
   [16] initialize_block!(ax::Axis)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks/axis.jl:160
   [17] _block(T::Type{Axis}, fig_or_scene::Figure, args::Vector{Any}, kwdict::Dict{Symbol, Any}, bbox::Nothing; kwdict_complete::Bool)
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:388
   [18] _block
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:308 [inlined]
   [19] #_block#1341
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:276 [inlined]
   [20] _block(::Type{Axis}, ::GridPosition; kwargs::Base.Pairs{Symbol, Any, NTuple{9, Symbol}, NamedTuple{(:aspect, :xtickformat, :ytickformat, :xticks, :yticks, :limits, :xticklabelpad, :yticklabelpad, :alignmode), Tuple{DataAspect, typeof(GeoMakie.longitude_format), typeof(GeoMakie.latitude_format), LinearTicks, LinearTicks, Tuple{Tuple{Float64, Float64}, Tuple{Int64, Int64}}, Float64, Float64, Outside}}})
      @ Makie ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:270
   [21] _block
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:263 [inlined]
   [22] #_#1339
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:254 [inlined]
   [23] Block
      @ ~/.julia/packages/Makie/pCA2E/src/makielayout/blocks.jl:253 [inlined]
   [24] GeoAxis(args::GridPosition; source::String, dest::Observable{String}, transformation::Proj.Transformation, lonlims::MakieCore.Automatic, latlims::Tuple{Int64, Int64}, coastlines::Bool, coastline_attributes::NamedTuple{(:label,), Tuple{String}}, line_density::Int64, remove_overlapping_ticks::Bool, xtickformat::typeof(GeoMakie.longitude_format), ytickformat::typeof(GeoMakie.latitude_format), xticks::LinearTicks, yticks::LinearTicks, xticklabelpad::Float64, yticklabelpad::Float64, alignmode::Outside, kw::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
      @ GeoMakie ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/src/geoaxis.jl:105
   [25] top-level scope
      @ ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/examples/rotating_earth.jl:6
   [26] include
      @ ./client.jl:478 [inlined]
   [27] macro expansion
      @ ./timing.jl:273 [inlined]
   [28] macro expansion
      @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:478 [inlined]
   [29] macro expansion
      @ ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40 [inlined]
   [30] macro expansion
      @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
   [31] (::var"#5#8"{Vector{String}})()
      @ Main ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40
  in expression starting at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/examples/rotating_earth.jl:6
PNG:       0.039880 seconds (323 allocations: 4.137 MiB)
PDF:       0.000859 seconds (361 allocations: 18.375 KiB)
rotating_earth: Test Failed at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:52
  Expression: begin
    savepath = "$(example_name).pdf"
    print(rpad("PDF: ", 9))
    #= /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:55 =# @time CairoMakie.save(savepath, Makie.current_figure())
    isfile(savepath) && filesize(savepath) > 1000
end

Stacktrace:
 [1] macro expansion
   @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:478 [inlined]
 [2] macro expansion
   @ ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:52 [inlined]
 [3] macro expansion
   @ ~/.julia/juliaup/julia-1.9.3+0.x64.linux.gnu/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
 [4] (::var"#5#8"{Vector{String}})()
   @ Main ~/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:40
Running world_population
Include: ┌ Warning: Found `resolution` in the theme when creating a `Scene`. The `resolution` keyword for `Scene`s and `Figure`s has been deprecated. Use `Figure(; size = ...` or `Scene(; size = ...)` instead, which better reflects that this is a unitless size and not a pixel resolution. The key could also come from `set_theme!` calls or related theming functions.
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/scenes.jl:220
┌ Warning: `.px_area` got renamed to `.viewport`, and means the area the scene maps to in device independent units, not pixels. Note, `size(scene) == widths(scene.viewport[])`
└ @ Makie ~/.julia/packages/Makie/pCA2E/src/deprecated.jl:9
  5.240673 seconds (4.46 M allocations: 218.531 MiB, 1.82% gc time, 69.06% compilation time)
PNG:       0.285762 seconds (241.04 k allocations: 21.843 MiB, 34.14% compilation time)
PDF:       0.235733 seconds (131.31 k allocations: 6.729 MiB, 20.19% compilation time)
Test Summary:           | Pass  Fail  Error  Total   Time
GeoMakie                |   23     2      2     27  37.1s
  Basics                |    1                   1   7.3s
  geo2basic             |    2                   2   0.0s
  Examples              |   20     2      2     24  29.8s
    axis_config         |    3                   3   2.4s
    basic               |    3                   3   0.6s
    contourf            |    3                   3   3.5s
    field_and_countries |    3                   3  11.3s
    orthographic        |    1     1      1      3   2.2s
    projections         |    3                   3   2.6s
    rotating_earth      |    1     1      1      3   0.5s
    world_population    |    3                   3   5.8s
ERROR: LoadError: Some tests did not pass: 23 passed, 2 failed, 2 errored, 0 broken.
in expression starting at /home/fcremer/Documents/NFDI4Earth/deliverables/D2.5_1-5_Overview_DC_tech/dev/GeoMakie/test/runtests.jl:9
ERROR: Package GeoMakie errored during testing

@briochemc
Copy link

So the errors when using Makie 0.20 seem to be related to GeoAxis too... But I can see in #163 that it uses 0.20 already! So what is stopping a merge? And how can we help with it?

@SimonDanisch
Copy link
Member

We don't have a lot of tests for GeoMakie, and #163 rewrites half of the package...
If you could test the PR and make sure that there are no regressions and write down what needs improving, it would be a big help!

@briochemc
Copy link

Well, I'm not sure I'm really capable of all that but I'll see if I can help...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pbouffard @SimonDanisch @briochemc @felixcremer @asinghvi17