Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commit-name] Commit names do not satisfy requirements #17

Open
mol-audit-bot opened this issue Jul 19, 2017 · 14 comments
Open

[commit-name] Commit names do not satisfy requirements #17

mol-audit-bot opened this issue Jul 19, 2017 · 14 comments

Comments

@mol-audit-bot
Copy link

Please use semantic commit names

@mol-audit-bot
Copy link
Author

Bad commit name by @claudiorodriguez and @web-flow:
15e7517
feat: upgrade canonical, add jest (#13)

BREAKING CHANGE: upgrades canonical
BREAKING CHANGE: adds separate react entry point (from canonical upgrade)

  • adds new jest config on new entry point

@claudiorodriguez
Copy link
Member

Commit complies with mol-fe guidelines

@mol-audit-bot
Copy link
Author

Re-opened: please use semantic commit names

@mol-audit-bot mol-audit-bot reopened this Jul 28, 2017
@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse and @claudiorodriguez:
2160491
Feat/add webpack config (#19)

  • feat: add eslint webpack confic

  • chore: remove hello world! from npm scripts

  • refactor: extract webpack config to configurations

following same pattern as eslint-config-canonical

  • docs: update README.md

@mol-audit-bot
Copy link
Author

All commit names satisfy requirements

@mol-audit-bot
Copy link
Author

Re-opened: please use semantic commit names

@mol-audit-bot mol-audit-bot reopened this Oct 23, 2017
@mol-audit-bot
Copy link
Author

Bad commit name by @carpasse:
0ab36cc
feat: forbid anonymous defaults

Everthing exported should be named. This change also discorages exports like:

export default {
  one,
  two,
  ...
}

Which prevent efficient treeshaking. As the compiler can't know what
can be needed on compile time.

BREAKING CHANGE: any anonymous export will fail from now on.

@carpasse
Copy link
Contributor

Not a bad commit message

@mol-audit-bot
Copy link
Author

Re-opened: please use semantic commit names

@mol-audit-bot mol-audit-bot reopened this Nov 14, 2017
@mol-audit-bot
Copy link
Author

Bad commit name by @Greenkeeper[bot] and @claudiorodriguez:
53b7a66
docs(readme): add Greenkeeper badge

@mol-audit-bot
Copy link
Author

Bad commit name by @claudiorodriguez:
53e0f8c
fix: disable import/no-namespace

@mol-audit-bot
Copy link
Author

Bad commit name by @claudiorodriguez:
d622962
fix: move canonical rules into package

Moves the rules in canonical inside the package
for ease of maintenance and to take control
of dependencies.

BREAKING CHANGE: removes ava rules

@mol-audit-bot
Copy link
Author

Bad commit name by @claudiorodriguez:
aafc230
fix: move react overrides to react config

There were some react overrides in the base config,
but they need to be in the react-specific config

@mol-audit-bot
Copy link
Author

Bad commit name by Vadim Dalecky and @streamich:
6d96ee2
feat: remove import/prefer-default-export and import/max-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants