Fixed achievements file not getting created if missing.

Author: wispborne

CHANGELOGS.md

@@ -1,3 +1,9 @@
+Version 1.5.5
+**MagicAchievements**
+- sorry
+- Fixed achievements file not getting created if missing.
+  - This prevented achievements from loading, crashing mods e.g. AotD: VoK.
+
 Version 1.5.4
 
 **MagicAchievements**

jars/MagicLib-Kotlin.jar

@@ -8,6 +8,6 @@
     {
       "major": "1",
       "minor": "5",
-      "patch": "4-RC01"
+      "patch": "5"
     }
 }

jars/MagicLib.jar

@@ -4,7 +4,7 @@
   "author": "Modding Community: Dark.Revenant, LazyWizard, Nicke, Originem, Rubi, Schaf-Unschaf, Snrasha, Tartiflette, Wisp, Wyvern...",
   "utility": "false",
   # Using the long version format lets the game correctly compare major/minor/patch versions.
-  "version": { "major": '1', "minor": '5', "patch": '4' },
+  "version": { "major": '1', "minor": '5', "patch": '5' },
   "description": "A collection of classes to aid modding. Not a mod in itself, but required by other mods.",
   "gameVersion": "0.98a-RC7",
   "dependencies": [

magiclib.version

@@ -215,11 +215,11 @@ public void advanceInCombat(float amount, List<InputEventAPI> events, boolean is
      */
     public void saveChanges() {
         getLogger().info("Saving achievements triggered by '" + spec.getId() + "' from mod '" + spec.getModName() + "'.");
-        MagicAchievementManager.getInstance().saveAchievements(true);
+        MagicAchievementManager.getInstance().saveAchievements(true, false);
     }
 
     private void saveChangesWithoutLogging() {
-        MagicAchievementManager.getInstance().saveAchievements(false);
+        MagicAchievementManager.getInstance().saveAchievements(false, false);
     }
 
     /**

mod_info.json

@@ -150,7 +150,7 @@ public void setAchievementsEnabled(boolean areAchievementsEnabled, boolean isSav
         } else {
             logger.info("MagicLib achievements are disabled.");
             removeIntel();
-            saveAchievements(true);
+            saveAchievements(true, false);
 
             if (isSaveLoaded) {
                 Global.getSector().removeTransientScriptsOfClass(MagicAchievementRunner.class);
@@ -221,13 +221,13 @@ public Map<String, MagicAchievement> getAchievements() {
     /**
      * This writes to disk.
      */
-    protected void saveAchievements(boolean printUnchangedResultToLog) {
+    protected void saveAchievements(boolean printUnchangedResultToLog, boolean forceSave) {
         JSONObject commonJson;
         JSONArray savedAchievements = new JSONArray();
 
         // Prevents accidentally wiping achievements if the feature is disabled on game load.
         // Also, no reason to save nothing anyway.
-        if (achievements.isEmpty()) {
+        if (!forceSave && achievements.isEmpty()) {
             return;
         }
 
@@ -246,7 +246,7 @@ protected void saveAchievements(boolean printUnchangedResultToLog) {
         try {
             newAchievementsJsonString = savedAchievements.toString(indent);
 
-            if (newAchievementsJsonString.equals(lastSavedJson)) {
+            if (!forceSave && newAchievementsJsonString.equals(lastSavedJson)) {
                 if (printUnchangedResultToLog) {
                     logger.info("Not saving achievements because they haven't changed.");
                 }
@@ -303,7 +303,7 @@ public void reloadAchievements(boolean isSaveGameLoaded) {
         try {
             // Create file if it doesn't exist.
             if (!Global.getSettings().fileExistsInCommon(commonFilename)) {
-                saveAchievements(true);
+                saveAchievements(true, true);
             }
 
             try {
@@ -314,7 +314,7 @@ public void reloadAchievements(boolean isSaveGameLoaded) {
                 logger.warn("Unable to load achievements from " + commonFilename + ", making a backup and remaking it.", ex);
                 Global.getSettings().writeTextFileToCommon(commonFilename + ".backup", Global.getSettings().readTextFileFromCommon(commonFilename));
                 Global.getSettings().deleteTextFileFromCommon(commonFilename);
-                saveAchievements(true);
+                saveAchievements(true, true);
                 commonJson = JSONUtils.loadCommonJSON(commonFilename);
                 savedAchievementsJson = commonJson.getJSONArray(achievementsJsonObjectKey);
             }