Merge remote-tracking branch 'lo-y-wni/bug_fix' into hotfix-v8.2.3 (PR #1283)

This merge corrects an indexing error for rvcuten in code blocks specific to the
Grell-Freitas scheme in the convection driver. Specifically, in the
convection_from_MPAS and convection_to_MPAS routines, rvcuten used (k,k) as
indexing in a loop, where (k,i) is needed.

Since the Grell-Freitas scheme does not provide momentum tendencies, the changes
in this merge have no impact on results.

* lo-y-wni/bug_fix:
  There is index error in variable rvcuten whose index is set to (k,k) in loops. But it should be (k,i) because similar variable rucuten has the index (k,i). The bug fixed is at Grell-Freitas parameterization block but since it does not provide momentum tendencies, there is no change to simulation results

Author: mgduda

src/core_atmosphere/physics/mpas_atmphys_driver_convection.F

@@ -744,7 +744,7 @@ subroutine convection_from_MPAS(dt_dyn,configs,mesh,sfc_input,diag_physics,tend_
              rqvblten_p(i,k,j)  = rqvblten(k,i)
              rqvdynten_p(i,k,j) = rqvdynten(k,i)
              rucuten_p(i,k,j)   = rucuten(k,i)
-             rvcuten_p(i,k,j)   = rvcuten(k,k)
+             rvcuten_p(i,k,j)   = rvcuten(k,i)
           enddo
        enddo
        enddo
@@ -941,7 +941,7 @@ subroutine convection_to_MPAS(configs,diag_physics,tend_physics,its,ite)
              qc_cu(k,i)    = qccu_p(i,k,j)
              qi_cu(k,i)    = qicu_p(i,k,j)
              rucuten(k,i)  = rucuten_p(i,k,j)
-             rvcuten(k,k)  = rvcuten_p(i,k,j)
+             rvcuten(k,i)  = rvcuten_p(i,k,j)
           enddo
        enddo
        enddo