Remove check enforcing activeStartTime < activeStopTime

Author: Andy Stokely

src/core_test/mpas_test_core_timekeeping_tests.F

@@ -294,7 +294,7 @@ end subroutine teardown_alarm_fixture
    !>   Timeline:
    !>      A ---------------- B ----- C ---------------- D --------- E
    !>
-   !>   The test covers 18 cases, including behavior:
+   !>   The test covers 17 cases, including behavior:
    !>   - Before anchor (A -> B)
    !>   - Between anchor and window start (B -> C)
    !>   - At window boundaries (C, D)
@@ -303,11 +303,9 @@ end subroutine teardown_alarm_fixture
    !>   - After reset operations at various points
    !>   - With anchor times shifted into the window
    !>   - When the clock direction changes (forward/backward)
-   !>   - When the window start time is after the stop time (invalid)
-   !>   - When the window start time equals the stop time (valid)
    !>
-   !>   Each case checks whether the alarm rings at the correct times and
-   !>   uses mpas_log_write to log PASS/FAIL outcomes.
+   !>   Each case verifies that the alarm rings at the correct times and
+   !>   logs only failures using mpas_log_write.
    !-----------------------------------------------------------------------
    subroutine test_window_alarm(case_idx, ierr)
       implicit none
@@ -526,32 +524,6 @@ subroutine test_window_alarm(case_idx, ierr)
          ringing = mpas_is_alarm_ringing(f%clock, f%alarm_id)
          call assert_false(ringing, 'Alarm is ringing outside of window after direction change', local_ierr)
          ierr = ierr + local_ierr
-
-         !-----------------------------------------------------------------------
-         !  Case 18: Invalid window ordering test
-         !>
-         !>   This test verifies that mpas_add_clock_alarm correctly handles
-         !>   window time validation:
-         !>     1. It must reject alarms where the start time occurs after the stop time.
-         !>     2. It must allow alarms where the start time equals the stop time.
-         !-----------------------------------------------------------------------
-      case(18)
-         ! Start time after stop time rejected
-         call mpas_remove_clock_alarm(f%clock, f%alarm_id)
-         call mpas_add_clock_alarm(f%clock, f%alarm_id, f%alarm_time, &
-                 alarmTimeInterval = f%alarm_interval, &
-                 alarmStartTime    = f%window_stop_time, &
-                 alarmStopTime     = f%window_start_time, ierr=local_ierr)
-         call assert_true(local_ierr /= 0, 'Alarm with start time after stop time did not return error', local_ierr)
-         ierr = ierr + local_ierr
-
-         call mpas_remove_clock_alarm(f%clock, f%alarm_id)
-         call mpas_add_clock_alarm(f%clock, f%alarm_id, f%alarm_time, &
-                 alarmTimeInterval = f%alarm_interval, &
-                 alarmStartTime    = f%window_start_time, &
-                 alarmStopTime     = f%window_start_time, ierr=local_ierr)
-         call assert_false(local_ierr /= 0, 'Alarm with equal start/stop times incorrectly returned error', local_ierr)
-         ierr = ierr + local_ierr
       end select
 
       call teardown_alarm_fixture(f)
@@ -572,8 +544,8 @@ integer function mpas_window_alarm_tests() result(ierr)
       integer :: i, ierr_local
 
       ierr = 0
-      call mpas_log_write('Running 18 window alarm tests')
-      do i = 1, 18
+      call mpas_log_write('Running 17 window alarm tests')
+      do i = 1, 17
          ierr_local = 0
          call test_window_alarm(i, ierr_local)
          ierr = ierr + ierr_local

src/framework/mpas_timekeeping.F

@@ -555,12 +555,6 @@ subroutine mpas_add_clock_alarm(clock, alarmID, alarmTime, alarmTimeInterval, &
          else
             alarmPtr % activeStopTime = mpas_get_clock_time(clock, MPAS_STOP_TIME)
          end if
-         if (alarmPtr % activeStartTime > alarmPtr % activeStopTime) then
-            call mpas_log_write('Invalid alarm times: start > stop for ' // trim(alarmID), MPAS_LOG_ERR)
-            if (present(ierr)) ierr = 1
-         end if
-
-
          if (present(alarmTimeInterval)) then
             alarmPtr % isRecurring = .true.
             alarmPtr % ringTimeInterval = alarmTimeInterval