Optimize SendItems serialization; small bugfix

Closes #27

Author: MP3Martin

server/GameInv/InventoryNS/Inventory.cs

@@ -147,7 +147,11 @@ public bool RemoveItem(Item item, bool noLog = false) {
         }
 
         public bool RemoveItem(string id, bool noLog = false) {
-            return RemoveItem(_items[GetItemIndex(id)], noLog);
+            var index = GetItemIndex(id);
+            // ReSharper disable once ConvertIfStatementToReturnStatement
+            if (index == -1) return false;
+
+            return RemoveItem(_items[index], noLog);
         }
 
         public bool ModifyItem(Item item) {

server/GameInv/Ws/WebSocketConnectionInterfaceWrapper.cs

@@ -2,7 +2,7 @@
 
 namespace GameInv.Ws {
     public class WebSocketConnectionInterfaceWrapper {
-        private const string AuthenticatedString = "authenticated";
+        private const string AuthenticatedString = "Authenticated";
         private readonly IWebSocketConnection _socketConnection;
 
         public WebSocketConnectionInterfaceWrapper(IWebSocketConnection socketConnection) {

server/GameInv/Ws/WsConnectionHandler.cs

@@ -97,18 +97,24 @@ private static void FailAuth(IWebSocketConnection socket) {
             Log.Info($"Socket {socket.ConnectionInfo.Id} failed auth");
         }
 
-        private void SendItems(WebSocketConnectionInterfaceWrapper socket) {
+        private void SendItems(WebSocketConnectionInterfaceWrapper? socket) {
             var items = _gameInv.Inventory.ToList();
             var itemsData = items.Select(i => (ItemData)i);
             var serializedItems = JsonConvert.SerializeObject(itemsData);
             var message = EncodeMessage("items", null, serializedItems);
-            socket.Send(message);
+
+            if (socket is not null) {
+                socket.Send(message);
+                return;
+            }
+
+            foreach (var sock in _allSockets.Values) {
+                sock.Send(message);
+            }
         }
 
         private void SendItems() {
-            foreach (var socket in _allSockets.Values) {
-                SendItems(socket);
-            }
+            SendItems(null);
         }
     }
 }