Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing annotations #24

Open
hariszaf opened this issue Sep 28, 2024 · 2 comments
Open

missing annotations #24

hariszaf opened this issue Sep 28, 2024 · 2 comments

Comments

@hariszaf
Copy link
Collaborator

In the gapfilled model, the annotations are most of the times missing.
Here is the SBO checks from MEMOTE in the originally modelSEEDpy built GEM and after gapfilling it with DNNGIOR:

image
image

I suggest a post-annotation step based on the non-gapfilled model.

@Biomerene
Copy link
Collaborator

As far as I know it should be done in the model_refinement function (in dnngior/build_model.py) where it uses the aliases assign all relevant annotations. We could add

 if hasattr(reaction, 'annotation'):
                    mc.reactions.get_by_id(reaction.id).annotation = reaction.annotation

at line 113 (where it copies the gpr) but that could be a less clean option.
I am working on some things in the develop branch where I can add this so it would be fixed when we merge my new features.

@hariszaf
Copy link
Collaborator Author

Sounds good to me since that way it would just inherit the annotations of the draft model.

Let me know if I could do anything to help. 🛩️

@hariszaf hariszaf mentioned this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants