-
Notifications
You must be signed in to change notification settings - Fork 2
Add app_metadata property to the token. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Update the instanciation of the inputs according to the documentation. Add the possibility to create app_metadata within the token.
|
@yageek Sorry, somehow missed the notification for your PR, i'll check this out today. |
|
@yageek Looking at an extension from luckymarmot itself, it appears there is usage of both types of input. Is there documentation for both? https://github.com/luckymarmot/Paw-JsonWebTokenDynamicValue/blob/master/src/JsonWebTokenDynamicValue.js#L10 |
|
@yageek I'm not seeing where the change happened, and I don't know what the difference is between |
|
The original purpose of the PR was to be able to provide fake value for the |
|
@yageek Yeah, i see that documentation, i guess what concerns me is there any functionality changes that could be breaking between the two input types. I'll have to go through the changelogs and see if they say anything about it. Also, are you sure |
|
@tacomanator Since you've been on a roll contributing to this project, can you verfiy that If they are 2 different things, maybe we should have a selection to choose the appropriate property? |
|
To be honest I don't use metadata right now, so not sure how to test. Is the metadata even included in the token? I thought metadata is sent with the signup request, and can be retrieved via the api. What does it have to do with the token? |
|
@tacomanator it's useful when you need data about the user when they login instead of making multiple requests before being able to do anything. By being embedded in the token, any request with that token has that vital information. I imagine though it's a small use case, only if the API you are sending the token to absolutely needs it |
|
@yageek Can you explain the exact use case for this? |
|
I was using the Authorization API that adds elements inside |
|
Yeah, so this Auth0 documentation states that it used to be |
Update the instanciation of the inputs according to the documentation.
Add the possibility to create app_metadata within the token.