Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open BAM and BAI files in the Add track menu #89

Closed
agduncan94 opened this issue Aug 12, 2020 · 2 comments
Closed

Open BAM and BAI files in the Add track menu #89

agduncan94 opened this issue Aug 12, 2020 · 2 comments
Labels
bug Something isn't working Controlled Access File Display wontfix This will not be worked on

Comments

@agduncan94
Copy link
Collaborator

It seems like the convention for naming some bam and bai files from the gdc are alignment.bam and alignment.bai. There is some JBrowse code that assumes the naming convention is something like alignment.bam and alignment.bam.bai. The bai file has the same name as the bam, but with .bai appended to it.

When you try to add the track using the Track -> Add track from file or URL, it assumes that the bam and bai files follow the naming convention mentioned above. This should be fixed to allow users to add these bam and bai files where the name, ignoring the .bam and .bam.bai is the same.

This is related to GMOD/jbrowse#1538.

@agduncan94
Copy link
Collaborator Author

Notes

  • code goes to BAMDriver.js
  • connected to multiindexedfiledriver

@GFJHogue
Copy link
Collaborator

This also appears to affect VCFs with their .tbi index files.

Seems to me that this won't change anytime soon.
This only really affects users uploading tracks manually, so it's probably not a big deal for them to rename index files...

As for our own "Add Files from GDC" interfaces, this doesn't affect us and the BAM store class doesn't care.
It's easy enough to hypothetically support uploading files on a gdc-viewer-specific interface.
Closing (and replacing with a new issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Controlled Access File Display wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants