adding integrations tests for Prod (#40)

* adding integrations tests for Prod
* lightning-sdk >=0.1.56

Author: Borda

.github/workflows/ci-testing.yml

@@ -3,7 +3,7 @@ name: CI testing
 # see: https://help.github.com/en/actions/reference/events-that-trigger-workflows
 on: # Trigger the workflow on push or pull request, but only for the main branch
   push: {}
-  pull_request:
+  pull_request_target:
     branches: [main]
 
 defaults:
@@ -47,9 +47,17 @@ jobs:
           pip install -e '.[test,extra]' -U -q --find-links $TORCH_URL
           pip list
 
-      - name: Tests
+      - name: Tests with mocks
         run: |
-          coverage run --source litmodels -m pytest src tests -v
+          coverage run --source litmodels -m pytest src tests -v -m "not cloud"
+
+      - name: Test integrations
+        env:
+          LIGHTNING_USER_ID: ${{ secrets.LIGHTNING_USER_ID }}
+          LIGHTNING_API_KEY: ${{ secrets.LIGHTNING_API_KEY }}
+        run: |
+          coverage run --source litmodels -m pytest src tests -v -m cloud
+        timeout-minutes: 5
 
       - name: Statistics
         run: |

pyproject.toml

@@ -31,6 +31,9 @@ addopts = [
     "--color=yes",
     "--disable-pytest-warnings",
 ]
+markers = [
+    "cloud:Run the cloud tests for example",
+]
 filterwarnings = [
     "error::FutureWarning",
 ]

requirements.txt

@@ -1,5 +1,5 @@
 # NOTE: once we add more dependencies, consider update dependabot to check for updates
 
-lightning-sdk >=0.1.40
+lightning-sdk >=0.1.56
 lightning-utilities
 joblib

tests/integrations/test_cloud.py

@@ -0,0 +1,51 @@
+import os
+from contextlib import redirect_stdout
+from io import StringIO
+
+import pytest
+from lightning_sdk.lightning_cloud.rest_client import GridRestClient
+from lightning_sdk.utils.resolve import _resolve_teamspace
+from litmodels import download_model, upload_model
+
+LIT_ORG = "lightning-ai"
+LIT_TEAMSPACE = "LitModels"
+
+
+@pytest.mark.cloud()
+def test_upload_download_model(tmp_path):
+    """Verify that the model is uploaded to the teamspace"""
+    # create a dummy file
+    file_path = tmp_path / "dummy.txt"
+    with open(file_path, "w") as f:
+        f.write("dummy")
+
+    # model name with random hash
+    model_name = f"litmodels_test_integrations+{os.urandom(8).hex()}"
+    teamspace = _resolve_teamspace(org=LIT_ORG, teamspace=LIT_TEAMSPACE, user=None)
+    org_team = f"{teamspace.owner.name}/{teamspace.name}"
+
+    out = StringIO()
+    with redirect_stdout(out):
+        upload_model(name=f"{org_team}/{model_name}", model=file_path)
+
+    # validate the output
+    assert (
+        f"Model uploaded successfully. Link to the model: 'https://lightning.ai/{org_team}/models/{model_name}'"
+    ) in out.getvalue()
+
+    os.remove(file_path)
+    assert not os.path.isfile(file_path)
+
+    model_files = download_model(name=f"{org_team}/{model_name}", download_dir=tmp_path)
+    assert model_files == ["dummy.txt"]
+    for file in model_files:
+        assert os.path.isfile(os.path.join(tmp_path, file))
+
+    client = GridRestClient()
+    # cleaning created models with todo: also consider how to delete just this version of the model
+    model = client.models_store_get_model_by_name(
+        project_owner_name=teamspace.owner.name,
+        project_name=teamspace.name,
+        model_name=model_name,
+    )
+    client.models_store_delete_model(project_id=teamspace.id, model_id=model.id)