0.4.0 tarballs #76
Comments
|
For a release on GitHub there is manual uploads and tarballs auto-generated from Git tag content.
What do you think? |
|
I see that effectively you have two separated projects in the same repo. |
|
It's not up to me to decide. Also undoing the split is another topic than release tarballs in my eyes. |
|
OK so just pass info the the decision making people that keeping multiple projects in one repo only will cause more difficulties and problems. |
|
@kloczek probably best to make a new ticket suggesting the split |
|
I have created two 0.4.0 GitHub releases by now with the original tarballs off SourceForge — created by
This is what you should see at https://github.com/Libvisual/libvisual/releases: I believe that addresses the issue and will hence close the issue as fixed. If that seems mistaken, please speak up. Thank you! |
|
Thank you 👍 |
|
FYI version 0.4.1 has just been released. |
|
I have problem with building that version because it irequires SDL to regenerate auto tools files. + cd libvisual-0.4.1
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: running: autopoint --force
Copying file m4/codeset.m4
Copying file m4/extern-inline.m4
Copying file m4/fcntl-o.m4
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4
Copying file m4/intldir.m4
Copying file m4/intmax.m4
Copying file m4/inttypes-pri.m4
Copying file m4/inttypes_h.m4
Copying file m4/lcmessage.m4
Copying file m4/lock.m4
Copying file m4/longlong.m4
Copying file m4/printf-posix.m4
Copying file m4/size_max.m4
Copying file m4/stdint_h.m4
Copying file m4/threadlib.m4
Copying file m4/uintmax_t.m4
Copying file m4/visibility.m4
Copying file m4/wchar_t.m4
Copying file m4/wint_t.m4
Copying file m4/xsize.m4
Copying file po/Makevars.template
autoreconf: running: aclocal --force -I m4
configure.ac:394: warning: macro 'AM_PATH_SDL' not found in library
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and rerunning libtoolize and aclocal.
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force -I m4
configure.ac:394: warning: macro 'AM_PATH_SDL' not found in library
autoreconf: running: /usr/bin/autoconf --force
configure.ac:23: warning: The macro `AC_CONFIG_HEADER' is obsolete.
configure.ac:23: You should run autoupdate.
./lib/autoconf/status.m4:719: AC_CONFIG_HEADER is expanded from...
configure.ac:23: the top level
configure.ac:97: warning: The macro `AC_LIBTOOL_WIN32_DLL' is obsolete.
configure.ac:97: You should run autoupdate.
m4/ltoptions.m4:148: AC_LIBTOOL_WIN32_DLL is expanded from...
configure.ac:97: the top level
configure.ac:97: warning: AC_LIBTOOL_WIN32_DLL: Remove this warning and the call to _LT_SET_OPTION when you
configure.ac:97: put the 'win32-dll' option into LT_INIT's first parameter.
./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from...
m4/ltoptions.m4:148: AC_LIBTOOL_WIN32_DLL is expanded from...
configure.ac:97: the top level
configure.ac:98: warning: The macro `AC_LIBTOOL_DLOPEN' is obsolete.
configure.ac:98: You should run autoupdate.
m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from...
configure.ac:98: the top level
configure.ac:98: warning: AC_LIBTOOL_DLOPEN: Remove this warning and the call to _LT_SET_OPTION when you
configure.ac:98: put the 'dlopen' option into LT_INIT's first parameter.
./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from...
m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from...
configure.ac:98: the top level
configure.ac:99: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
configure.ac:99: You should run autoupdate.
m4/libtool.m4:100: AC_PROG_LIBTOOL is expanded from...
configure.ac:99: the top level
configure.ac:114: warning: The macro `AC_HEADER_STDC' is obsolete.
configure.ac:114: You should run autoupdate.
./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from...
configure.ac:114: the top level
configure.ac:121: warning: The macro `AC_HEADER_TIME' is obsolete.
configure.ac:121: You should run autoupdate.
./lib/autoconf/headers.m4:743: AC_HEADER_TIME is expanded from...
configure.ac:121: the top level
configure.ac:124: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:124: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:124: the top level
configure.ac:132: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:132: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:132: the top level
configure.ac:196: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:196: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:196: the top level
configure.ac:213: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:213: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:213: the top level
configure.ac:218: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:218: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:218: the top level
configure.ac:277: warning: The macro `AC_TRY_RUN' is obsolete.
configure.ac:277: You should run autoupdate.
./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
configure.ac:277: the top level
configure.ac:277: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2894: _AC_LINK_IFELSE is expanded from...
./lib/autoconf/general.m4:2911: AC_LINK_IFELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2981: AC_RUN_IFELSE is expanded from...
./lib/autoconf/general.m4:2997: AC_TRY_RUN is expanded from...
configure.ac:277: the top level
configure.ac:378: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:378: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:378: the top level
configure.ac:405: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:405: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:405: the top level
configure.ac:422: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:422: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:422: the top level
configure.ac:436: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:436: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
configure.ac:436: the top level
configure.ac:454: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:454: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:454: the top level
configure.ac:476: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:476: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:476: the top level
configure.ac:394: error: possibly undefined macro: AM_PATH_SDL
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation. |
|
Here is proposed patch --- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
dnl Process this file with autoconf to produce a configure script.
-AC_PREREQ(2.57)
+AC_PREREQ([2.69])
dnl Version numbers
m4_define([libvisual_version_major], [0])
@@ -20,7 +20,7 @@
LIBVISUAL_VERSION_SUFFIX="$LIBVISUAL_VERSION_MAJOR.$LIBVISUAL_VERSION_MINOR"
AC_SUBST(LIBVISUAL_VERSION_SUFFIX)
-AC_CONFIG_HEADER(config.h)
+AC_CONFIG_HEADERS([config.h])
AC_CANONICAL_HOST
@@ -94,46 +94,37 @@
AC_PROG_MAKE_SET
AC_DISABLE_STATIC
-AC_LIBTOOL_WIN32_DLL
-AC_LIBTOOL_DLOPEN
-AC_PROG_LIBTOOL
+LT_INIT([dlopen win32-dll])
PKG_PROG_PKG_CONFIG
-if test x$PKG_CONFIG = x ; then
- AC_MSG_ERROR([*** pkg-config not found. See http://www.freedesktop.org/software/pkgconfig/.
- *** You will need pkg-config to compile against Libvisual Library])
-fi
-if $PKG_CONFIG --atleast-pkgconfig-version 0.14 ; then
- :
-else
- AC_MSG_WARN([*** pkg-config too old; version 0.14 or better recommended.])
-fi
# Checks for header files.
AC_HEADER_DIRENT
-AC_HEADER_STDC
+AC_CHECK_INCLUDES_DEFAULT
+AC_PROG_EGREP
+
AC_CHECK_HEADERS([fcntl.h sys/types.h stdlib.h string.h sys/time.h unistd.h sched.h sys/sched.h])
# Checks for typedefs, structures, and compiler characteristics.
AC_C_CONST
AC_C_INLINE
AC_TYPE_SIZE_T
-AC_HEADER_TIME
+AC_CHECK_HEADERS_ONCE([sys/time.h])
AC_MSG_CHECKING(for ISO C99 varargs macros in C)
-AC_TRY_COMPILE([],[
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[
int a(int p1, int p2, int p3);
#define call_a(...) a(1,__VA_ARGS__)
call_a(2,3);
- ],lv_have_iso_c_varargs=yes,lv_have_iso_c_varargs=no)
+ ]])],[lv_have_iso_c_varargs=yes],[lv_have_iso_c_varargs=no])
AC_MSG_RESULT($lv_have_iso_c_varargs)
AC_MSG_CHECKING(for GNUC varargs macros)
-AC_TRY_COMPILE([],[
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[
int a(int p1, int p2, int p3);
#define call_a(params...) a(1,params)
call_a(2,3);
- ],lv_have_gnuc_varargs=yes,lv_have_gnuc_varargs=no)
+ ]])],[lv_have_gnuc_varargs=yes],[lv_have_gnuc_varargs=no])
AC_MSG_RESULT($lv_have_gnuc_varargs)
AC_C_BIGENDIAN(bigendian=yes, bigendian=no, )
@@ -193,10 +184,10 @@
to the compiler name."
AC_ARG_ENABLE([threads],
- AC_HELP_STRING([--enable-threads],
+ AS_HELP_STRING([--enable-threads],
[Turn on basic thread support @<:@default=enabled@:>@]),
- [enable_threads=$enableval],
- [enable_threads=yes])
+ [enable_threads=$enableval],
+ [enable_threads=yes])
AC_MSG_CHECKING([whether to enable thread support])
if test x$enable_threads = xyes; then
AC_MSG_RESULT([yes])
@@ -210,15 +201,11 @@
;;
esac
if test "x$have_threads" = xnone; then
- AC_TRY_COMPILE([#include <pthread.h>],
- [pthread_mutex_t m = PTHREAD_MUTEX_INITIALIZER;],
- have_threads=posix)
+ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <pthread.h>]], [[pthread_mutex_t m = PTHREAD_MUTEX_INITIALIZER;]])],[have_threads=posix],[])
fi
if test "x$have_threads" = xnone; then
- AC_TRY_COMPILE([#include <pthread.h>],
- [pthread_mutex_t m;
- pthread_mutex_init (&m, pthread_mutexattr_default);],
- have_threads=dce)
+ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <pthread.h>]], [[pthread_mutex_t m;
+ pthread_mutex_init (&m, pthread_mutexattr_default);]])],[have_threads=dce],[])
fi
if test "x$have_threads" = xnone; then
PKG_CHECK_MODULES(GTHREAD2, gthread-2.0 >= 2.2.0, [have_gthread2="yes"], [have_gthread2="no"])
@@ -274,10 +261,7 @@
LIBS="$add_thread_lib $lv_save_LIBS"
AC_MSG_CHECKING(for pthread_create/pthread_join$IN)
- AC_TRY_RUN(lv_thread_test($defattr),
- lv_result=yes,
- lv_result=no,
- [AC_LINK_IFELSE(lv_thread_test($defattr),
+ AC_RUN_IFELSE([AC_LANG_SOURCE([[lv_thread_test($defattr)]])],[lv_result=yes],[lv_result=no],[AC_LINK_IFELSE(lv_thread_test($defattr),
lv_result=yes,
lv_result=no)])
AC_MSG_RESULT($lv_result)
@@ -375,23 +359,14 @@
dnl Arguments to specify certain features.
dnl ******************************
AC_ARG_ENABLE([examples],
- AC_HELP_STRING([--disable-examples],
- [Do not build example programs @<:@default=enabled@:>@]),
- [examples=$enableval],
- [examples=yes])
+ AS_HELP_STRING([--disable-examples],
+ [Do not build example programs @<:@default=enabled@:>@]),
+ [examples=$enableval],
+ [examples=yes])
AC_MSG_CHECKING([wheter to build example programs])
if test x$examples = xyes ; then
AC_MSG_RESULT([yes])
- # Find SDL to build the examples.
- AC_PATH_TOOL(SDL_CONFIG, [sdl-config])
- if test x$SDL_CONFIG = x ; then
- AC_MSG_ERROR([*** sdl-config not found.
- If you have installed from binaries, probably you have not
- installed SDL development package.
- See http://www.libsdl.org])
- fi
- # On success, this will set and substitute SDL_CFLAGS and SDL_LIBS
- AM_PATH_SDL(1.2.0,,AC_MSG_ERROR([*** SDL >= 1.2.0 not installed - please install first]))
+ PKG_CHECK_MODULES(SDL, [sdl >= 1.2.0])
AC_SUBST([EXAMPLES], ['simplesdl morphsdl'])
else
AC_MSG_RESULT([no])
@@ -402,10 +377,10 @@
dnl ******************************
DEBUG_CFLAGS=""
AC_ARG_ENABLE([profiling],
- AC_HELP_STRING([--enable-profiling],
+ AS_HELP_STRING([--enable-profiling],
[Enable emision of profile data to be used by gprof @<:@default=disabled@:>@]),
- [profiling=$enableval],
- [profiling=no])
+ [profiling=$enableval],
+ [profiling=no])
AC_MSG_CHECKING([whether to enable profiling])
if test x$profiling = xyes; then
AC_MSG_RESULT([yes])
@@ -419,10 +394,10 @@
fi
AC_ARG_ENABLE([debug],
- AC_HELP_STRING([--enable-debug],
- [Enable debug @<:@default=disabled@:>@]),
- [debug=$enableval],
- [debug=no])
+ AS_HELP_STRING([--enable-debug],
+ [Enable debug @<:@default=disabled@:>@]),
+ [debug=$enableval],
+ [debug=no])
AC_MSG_CHECKING([whether to enable debug])
if test x$debug = xyes; then
AC_MSG_RESULT([yes])
@@ -433,10 +408,7 @@
lv_save_CFLAGS=$CFLAGS
CFLAGS="$CFLAGS -Wno-unused-variable"
AC_MSG_CHECKING([whether gcc version is greater than 2.95])
- AC_TRY_COMPILE([#include <stdlib.h>],
- [exit(0);],
- [lv_gcc_gt_2_95=yes],
- [lv_gcc_gt_2_95=no])
+ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <stdlib.h>]], [[exit(0);]])],[lv_gcc_gt_2_95=yes],[lv_gcc_gt_2_95=no])
CFLAGS=$lv_save_CFLAGS
if test x$lv_gcc_gt_2_95 = xyes ; then
AC_MSG_RESULT([yes])
@@ -451,10 +423,10 @@
AC_SUBST(DEBUG_CFLAGS)
AC_ARG_ENABLE([extra-optimization],
- AC_HELP_STRING([--enable-extra-optimization],
- [Enable extra optimizations @<:@default=disabled@:>@]),
- [extra_opt=$enableval],
- [extra_opt=no])
+ AS_HELP_STRING([--enable-extra-optimization],
+ [Enable extra optimizations @<:@default=disabled@:>@]),
+ [extra_opt=$enableval],
+ [extra_opt=no])
AC_MSG_CHECKING([whether to enable extra optimizations])
if test x$extra_opt = xyes; then
AC_MSG_RESULT([yes])
@@ -473,10 +445,10 @@
fi
AC_ARG_ENABLE([fast-fp-rng],
- AC_HELP_STRING([--enable-fast-fp-rng],
- [Enable faster random floating point generator (enabled by default if --enable-extra-optimization is passed) ]),
- [fastfprng=$enableval],
- [fastfprng=maybe])
+ AS_HELP_STRING([--enable-fast-fp-rng],
+ [Enable faster random floating point generator (enabled by default if --enable-extra-optimization is passed) ]),
+ [fastfprng=$enableval],
+ [fastfprng=maybe])
AC_MSG_CHECKING([whether to enable fast FP RNG])
if test x$fastfprng = xyes; thenHowever I cannot test tath because it is something wrong with threads library detection checking whether to enable thread support... yes
checking for thread implementation available... posix
checking for pthread_create/pthread_join... no
checking for pthread_create/pthread_join in -lpthread... no
checking for pthread_create/pthread_join in -lpthread32... no
checking for pthread_create/pthread_join in -lpthreads... no
checking for pthread_create/pthread_join in -lthread... no
checking for pthread_create/pthread_join in -ldce... no
configure: error: I can't find the libraries for the thread implementation
posix. Please choose another thread implementation or
provide information on your thread implementation.
You can also run 'configure --disable-threads'
to compile without thread support. |
|
I think that instead using custom threads detection better would be use standard OOTB |
|
Because at the end of the configureac is threads enable/disable code which is using gthread-2.0 I;ve decided to remove all other threads detection bits becaue it does not make to much sense and nothing is using any AC_SUBST() generated parts. --- a/configure.ac
+++ b/configure.ac
@@ -152,37 +152,6 @@
dnl Check for native thread support
dnl -------------------------------
-dnl
-dnl Test program for basic POSIX threads functionality (taken from Glib)
-dnl
-m4_define([lv_thread_test],[
-#include <stdlib.h>
-#include <pthread.h>
-int check_me = 0;
-void* func(void* data) {check_me = 42; return &check_me;}
-int main()
- { pthread_t t;
- void *ret;
- pthread_create (&t, $1, func, 0);
- pthread_join (t, &ret);
- exit (check_me != 42 || ret != &check_me);
-}])
-
-LIBS_NOT_FOUND_1="I can't find the libraries for the thread implementation
- "
-
-LIBS_NOT_FOUND_2=". Please choose another thread implementation or
- provide information on your thread implementation.
- You can also run 'configure --disable-threads'
- to compile without thread support."
-
-AIX_COMPILE_INFO="AIX's C compiler needs to be called by a different name, when
- linking threaded applications. As Libvisual cannot do that
- automatically, you will get an linkg error everytime you are
- not using the right compiler. In that case you have to relink
- with the right compiler. Ususally just '_r' is appended
- to the compiler name."
-
AC_ARG_ENABLE([threads],
AS_HELP_STRING([--enable-threads],
[Turn on basic thread support @<:@default=enabled@:>@]),
@@ -195,91 +195,6 @@
fi
fi
-
-dnl ------------------------------------------------
-dnl Determination of linker flags for thread support
-dnl ------------------------------------------------
-
-LV_THREAD_LIBS=""
-if test "x$enable_threads" = xyes && test "x$have_threads" != xnone; then
- case $have_threads in
- posix|dce)
- case $host in
- *-aix*)
- # We are not using gcc (would have set LV_THREAD_LIBS) and thus
- # probably using the aix compiler.
- AC_MSG_WARN($AIX_COMPILE_INFO)
- ;;
- *)
- LV_THREAD_LIBS=error
- lv_save_LIBS="$LIBS"
- for thread_lib in "" pthread pthread32 pthreads thread dce; do
- if test x"$thread_lib" = x; then
- add_thread_lib=""
- IN=""
-else
- add_thread_lib="-l$thread_lib"
- IN=" in -l$thread_lib"
- fi
- if test x"$have_threads" = xposix; then
- defattr=0
- else
- defattr=pthread_attr_default
- fi
-
- LIBS="$add_thread_lib $lv_save_LIBS"
-
- AC_MSG_CHECKING(for pthread_create/pthread_join$IN)
- AC_RUN_IFELSE([AC_LANG_SOURCE([[lv_thread_test($defattr)]])],[lv_result=yes],[lv_result=no],[AC_LINK_IFELSE(lv_thread_test($defattr),
- lv_result=yes,
- lv_result=no)])
- AC_MSG_RESULT($lv_result)
-
- if test "$lv_result" = "yes" ; then
- LV_THREAD_LIBS="$add_thread_lib"
- break
- fi
- done
-
- if test "x$LV_THREAD_LIBS" = xerror; then
- AC_MSG_ERROR($LIBS_NOT_FOUND_1$have_threads$LIBS_NOT_FOUND_2)
-fi
-
- LIBS="$lv_save_LIBS"
- ;;
- esac
- ;;
- gthread2)
- LV_THREAD_LIBS="$GTHREAD2_LIBS"
- ;;
- *)
- ;;
- esac
-else
- # Thread support disabled
- :
-fi
-
-AC_MSG_CHECKING(thread related libraries)
-AC_MSG_RESULT($LV_THREAD_LIBS)
-AC_SUBST(LV_THREAD_LIBS)
-
-dnl --------------------------------------------------
-dnl Determination of compiler flags for thread support
-dnl --------------------------------------------------
-
-LV_THREAD_CFLAGS=""
-if test "x$enable_threads" = xyes && test "x$have_threads" != xnone; then
- case $have_threads in
- gthread2)
- LV_THREAD_CFLAGS="$GTHREAD2_CFLAGS"
- ;;
- *)
- ;;
- esac
-fi
-AC_SUBST(LV_THREAD_CFLAGS)
-
# check for type sizes
AC_CHECK_SIZEOF(short)
AC_CHECK_SIZEOF(int)With that I was able to test default examples build checking wheter to build example programs... yes
checking for sdl >= 1.2.0... no
configure: error: Package requirements (sdl >= 1.2.0) were not met:
Package 'sdl', required by 'virtual:world', not found
Consider adjusting the PKG_CONFIG_PATH environment variable if youand after disable building examples I was able to build libvisual however I found as well some compile time warnings lv_video_simd.c: In function '_lv_blit_overlay_alphasrc_mmx':
lv_video_simd.c:40:17: warning: unused variable 'alpha' [-Wunused-variable]
40 | uint8_t alpha;
| ^~~~~
lv_mem.c: In function 'mem_copy_altivec':
lv_mem.c:379:1: warning: no return statement in function returning non-void [-Wreturn-type]
379 | }
| ^
lv_mem.c: In function 'mem_set8_altivec':
lv_mem.c:529:1: warning: no return statement in function returning non-void [-Wreturn-type]
529 | }
| ^
lv_mem.c: In function 'mem_set16_altivec':
lv_mem.c:673:1: warning: no return statement in function returning non-void [-Wreturn-type]
673 | }
| ^
lv_mem.c: In function 'mem_set32_altivec':
lv_mem.c:784:1: warning: no return statement in function returning non-void [-Wreturn-type]
784 | }
| ^
lv_mem.c: At top level:
lv_mem.c:781:14: warning: 'mem_set32_altivec' defined but not used [-Wunused-function]
781 | static void *mem_set32_altivec (void *dest, int c, visual_size_t n)
| ^~~~~~~~~~~~~~~~~
lv_mem.c:670:14: warning: 'mem_set16_altivec' defined but not used [-Wunused-function]
670 | static void *mem_set16_altivec (void *dest, int c, visual_size_t n)
| ^~~~~~~~~~~~~~~~~
lv_mem.c:526:14: warning: 'mem_set8_altivec' defined but not used [-Wunused-function]
526 | static void *mem_set8_altivec (void *dest, int c, visual_size_t n)
| ^~~~~~~~~~~~~~~~
lv_mem.c:376:14: warning: 'mem_copy_altivec' defined but not used [-Wunused-function]
376 | static void *mem_copy_altivec (void *dest, const void *src, visual_size_t n)
| ^~~~~~~~~~~~~~~~
lv_libvisual.c: In function 'free_plugpaths':
lv_libvisual.c:196:1: warning: control reaches end of non-void function [-Wreturn-type]
196 | }
| ^
In file included from lv_cpu.c:76:
gettext.h:71: warning: "gettext_noop" redefined
71 | #define gettext_noop(String) String
|
gettext.h:49: note: this is the location of the previous definition
49 | # define gettext_noop(Msgid) ((const char *) (Msgid))
|
lv_cpu.c: In function 'visual_cpu_initialize':
lv_cpu.c:400:23: warning: unused variable 'len' [-Wunused-variable]
400 | visual_size_t len;
| ^~~
lv_cpu.c:399:21: warning: unused variable 'ncpu' [-Wunused-variable]
399 | int mib[2], ncpu;
| ^~~~
lv_cpu.c:399:13: warning: unused variable 'mib' [-Wunused-variable]
399 | int mib[2], ncpu;
| ^~~
lv_cpu.c:397:22: warning: unused variable 'regs2' [-Wunused-variable]
397 | unsigned int regs2[4];
| ^~~~~
lv_cpu.c:396:22: warning: unused variable 'regs' [-Wunused-variable]
396 | unsigned int regs[4];
| ^~~~
lv_cpu.c:395:18: warning: unused variable 'cpu_flags' [-Wunused-variable]
395 | uint32_t cpu_flags;
| ^~~~~~~~~
lv_cpu.c: At top level:
lv_cpu.c:363:12: warning: 'cpuid' defined but not used [-Wunused-function]
363 | static int cpuid (unsigned int ax, unsigned int *p)
| ^~~~~
lv_cpu.c:339:12: warning: 'has_cpuid' defined but not used [-Wunused-function]
339 | static int has_cpuid (void)
| ^~~~~~~~~
lv_cpu.c:236:13: warning: 'check_os_katmai_support' defined but not used [-Wunused-function]
236 | static void check_os_katmai_support( void )
| ^~~~~~~~~~~~~~~~~~~~~~~
lv_rectangle.c: In function 'visual_rectangle_denormalise_many_values':
lv_rectangle.c:342:13: warning: unused variable 'i' [-Wunused-variable]
342 | int i;
| ^
lv_rectangle.c: In function 'visual_rectangle_new':
lv_rectangle.c:52:9: warning: 'rect' is used uninitialized [-Wuninitialized]
52 | visual_object_initialize (VISUAL_OBJECT (rect), TRUE, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_rectangle.c:49:23: note: 'rect' was declared here
49 | VisRectangle *rect;
| ^~~~
lv_bmp.c: In function 'load_uncompressed':
lv_bmp.c:75:61: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
75 | uint8_t *end = (uint8_t *) ((int)data & ~1);
| ^
lv_bmp.c:75:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
75 | uint8_t *end = (uint8_t *) ((int)data & ~1);
| ^
lv_bmp.c:96:61: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
96 | uint8_t *end = (uint8_t *) ((int)data & ~7);
| ^
lv_bmp.c:96:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
96 | uint8_t *end = (uint8_t *) ((int)data & ~7);
| ^
lv_bmp.c: In function 'visual_bitmap_load':
lv_bmp.c:285:9: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
285 | fread (magic, 2, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:293:9: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
293 | fread (&bf_size, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:300:9: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
300 | fread (&bf_bits, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:304:9: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
304 | fread (&bi_size, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:309:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
309 | fread (&bi_width, 2, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:310:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
310 | fread (&bi_height, 2, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:318:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
318 | fread (&bi_bitcount, 2, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:323:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
323 | fread (&bi_width, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:324:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
324 | fread (&bi_height, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:332:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
332 | fread (&bi_bitcount, 2, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:336:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
336 | fread (&bi_compression, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_bmp.c:343:17: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [-Wunused-result]
343 | fread (&bi_clrused, 4, 1, fp);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lv_collection.c:33:12: warning: 'collection_iter_dtor' defined but not used [-Wunused-function]
33 | static int collection_iter_dtor (VisObject *object)
| ^~~~~~~~~~~~~~~~~~~~
In file included from lv_ringbuffer.c:29:
./gettext.h:71: warning: "gettext_noop" redefined
71 | #define gettext_noop(String) String
|
./gettext.h:49: note: this is the location of the previous definition
49 | # define gettext_noop(Msgid) ((const char *) (Msgid))
|
lv_ringbuffer.c: In function 'visual_ringbuffer_get_data_offset':
lv_ringbuffer.c:257:13: warning: unused variable 'positioncorr' [-Wunused-variable]
257 | int positioncorr = 0;
| ^~~~~~~~~~~~
lv_ringbuffer.c:256:13: warning: unused variable 'curoffset' [-Wunused-variable]
256 | int curoffset = 0;
| ^~~~~~~~~
lv_ringbuffer.c: In function 'fixate_with_partial_data_request':
lv_ringbuffer.c:340:13: warning: unused variable 'curposition' [-Wunused-variable]
340 | int curposition = 0;
| ^~~~~~~~~~~
lv_morph.c: In function 'visual_morph_get_supported_depth':
lv_morph.c:243:24: warning: unused variable 'plugin' [-Wunused-variable]
243 | VisPluginData *plugin;
| ^~~~~~
lv_morph.c: In function 'visual_morph_get_video_attribute_options':
lv_morph.c:259:24: warning: unused variable 'plugin' [-Wunused-variable]
259 | VisPluginData *plugin;
| ^~~~~~
lv_thread.c: In function 'mutex_new_win32':
lv_thread.c:659:1: warning: no return statement in function returning non-void [-Wreturn-type]
659 | }
| ^
lv_thread.c: In function 'mutex_free_win32':
lv_thread.c:666:1: warning: no return statement in function returning non-void [-Wreturn-type]
666 | }
| ^
lv_thread.c: In function 'mutex_init_win32':
lv_thread.c:673:1: warning: no return statement in function returning non-void [-Wreturn-type]
673 | }
| ^
lv_thread.c: In function 'mutex_lock_win32':
lv_thread.c:680:1: warning: no return statement in function returning non-void [-Wreturn-type]
680 | }
| ^
lv_thread.c: In function 'mutex_trylock_win32':
lv_thread.c:687:1: warning: no return statement in function returning non-void [-Wreturn-type]
687 | }
| ^
lv_thread.c: In function 'mutex_unlock_win32':
lv_thread.c:694:1: warning: no return statement in function returning non-void [-Wreturn-type]
694 | }
| ^
lv_thread.c: At top level:
lv_thread.c:814:12: warning: 'mutex_unlock_gthread' defined but not used [-Wunused-function]
814 | static int mutex_unlock_gthread (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~~~
lv_thread.c:802:12: warning: 'mutex_trylock_gthread' defined but not used [-Wunused-function]
802 | static int mutex_trylock_gthread (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~~~~
lv_thread.c:790:12: warning: 'mutex_lock_gthread' defined but not used [-Wunused-function]
790 | static int mutex_lock_gthread (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~
lv_thread.c:779:12: warning: 'mutex_init_gthread' defined but not used [-Wunused-function]
779 | static int mutex_init_gthread (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~
lv_thread.c:768:12: warning: 'mutex_free_gthread' defined but not used [-Wunused-function]
768 | static int mutex_free_gthread (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~
lv_thread.c:753:18: warning: 'mutex_new_gthread' defined but not used [-Wunused-function]
753 | static VisMutex *mutex_new_gthread ()
| ^~~~~~~~~~~~~~~~~
lv_thread.c:745:13: warning: 'thread_yield_gthread' defined but not used [-Wunused-function]
745 | static void thread_yield_gthread ()
| ^~~~~~~~~~~~~~~~~~~~
lv_thread.c:738:13: warning: 'thread_exit_gthread' defined but not used [-Wunused-function]
738 | static void thread_exit_gthread (void *retval)
| ^~~~~~~~~~~~~~~~~~~
lv_thread.c:723:14: warning: 'thread_join_gthread' defined but not used [-Wunused-function]
723 | static void *thread_join_gthread (VisThread *thread)
| ^~~~~~~~~~~~~~~~~~~
lv_thread.c:718:12: warning: 'thread_free_gthread' defined but not used [-Wunused-function]
718 | static int thread_free_gthread (VisThread *thread)
| ^~~~~~~~~~~~~~~~~~~
lv_thread.c:697:19: warning: 'thread_create_gthread' defined but not used [-Wunused-function]
697 | static VisThread *thread_create_gthread (VisThreadFunc func, void *data, int joinable)
| ^~~~~~~~~~~~~~~~~~~~~
lv_thread.c:689:12: warning: 'mutex_unlock_win32' defined but not used [-Wunused-function]
689 | static int mutex_unlock_win32 (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~
lv_thread.c:682:12: warning: 'mutex_trylock_win32' defined but not used [-Wunused-function]
682 | static int mutex_trylock_win32 (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~~~~
lv_thread.c:675:12: warning: 'mutex_lock_win32' defined but not used [-Wunused-function]
675 | static int mutex_lock_win32 (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~
lv_thread.c:668:12: warning: 'mutex_init_win32' defined but not used [-Wunused-function]
668 | static int mutex_init_win32 (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~
lv_thread.c:661:12: warning: 'mutex_free_win32' defined but not used [-Wunused-function]
661 | static int mutex_free_win32 (VisMutex *mutex)
| ^~~~~~~~~~~~~~~~
lv_thread.c:654:18: warning: 'mutex_new_win32' defined but not used [-Wunused-function]
654 | static VisMutex *mutex_new_win32 ()
| ^~~~~~~~~~~~~~~
lv_thread.c:646:13: warning: 'thread_yield_win32' defined but not used [-Wunused-function]
646 | static void thread_yield_win32 ()
| ^~~~~~~~~~~~~~~~~~
lv_thread.c:639:13: warning: 'thread_exit_win32' defined but not used [-Wunused-function]
639 | static void thread_exit_win32 (void *retval)
| ^~~~~~~~~~~~~~~~~
lv_thread.c:619:14: warning: 'thread_join_win32' defined but not used [-Wunused-function]
619 | static void *thread_join_win32 (VisThread *thread)
| ^~~~~~~~~~~~~~~~~
lv_thread.c:614:12: warning: 'thread_free_win32' defined but not used [-Wunused-function]
614 | static int thread_free_win32 (VisThread *thread)
| ^~~~~~~~~~~~~~~~~
lv_thread.c:584:19: warning: 'thread_create_win32' defined but not used [-Wunused-function]
584 | static VisThread *thread_create_win32 (VisThreadFunc func, void *data, int joinable)
| ^~~~~~~~~~~~~~~~~~~
lv_fourier.c: In function 'visual_dft_perform':
lv_fourier.c:479:22: warning: unused variable 'i' [-Wunused-variable]
479 | unsigned int i;
| ^
lv_fourier.c: In function 'visual_dft_log_scale_standard':
lv_fourier.c:545:13: warning: unused variable 'i' [-Wunused-variable]
545 | int i;
| ^
lv_fourier.c: At top level:
lv_fourier.c:84:12: warning: 'log_scale_cache_destroy' declared 'static' but never defined [-Wunused-function]
84 | static int log_scale_cache_destroy (VisObject *object);
| ^~~~~~~~~~~~~~~~~~~~~~~
lv_hashmap.c: In function 'hashmap_destroy':
lv_hashmap.c:69:26: warning: unused variable 'mentry' [-Wunused-variable]
69 | VisHashmapEntry *mentry;
| ^~~~~~
lv_hashmap.c:67:36: warning: unused variable 'destroyer' [-Wunused-variable]
67 | VisCollectionDestroyerFunc destroyer;
| ^~~~~~~~~
lv_hashmap.c: In function 'hashmap_chain_destroy':
lv_hashmap.c:101:1: warning: no return statement in function returning non-void [-Wreturn-type]
101 | }
| ^
lv_hashmap.c: In function 'hashmap_iter':
lv_hashmap.c:128:21: warning: unused variable 'hashmap' [-Wunused-variable]
128 | VisHashmap *hashmap = VISUAL_HASHMAP (collection);
| ^~~~~~~
lv_hashmap.c: In function 'hashmap_iter_next':
lv_hashmap.c:203:21: warning: unused variable 'hashmap' [-Wunused-variable]
203 | VisHashmap *hashmap = VISUAL_HASHMAP (collection);
| ^~~~~~~
lv_hashmap.c: In function 'get_hash':
lv_hashmap.c:264:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
264 | else if (keytype = VISUAL_HASHMAP_KEY_TYPE_STRING)
| ^~~~~~~
lv_hashmap.c: In function 'visual_hashmap_set_table_size':
lv_hashmap.c:505:13: warning: unused variable 'oldsize' [-Wunused-variable]
505 | int oldsize;
| ^~~~~~~
lv_ui.c: In function 'visual_ui_box_get_childs':
lv_ui.c:343:23: warning: unused variable 'le' [-Wunused-variable]
343 | VisListEntry *le = NULL;
| ^~
lv_ui.c:342:22: warning: unused variable 'next' [-Wunused-variable]
342 | VisUIWidget *next;
| ^~~~
lv_ui.c: In function 'visual_ui_choice_add_many':
lv_ui.c:1069:27: warning: unused variable 'centry' [-Wunused-variable]
1069 | VisUIChoiceEntry *centry;
| ^~~~~~
lv_plugin.c: In function 'visual_plugin_get_references':
lv_plugin.c:820:21: warning: unused variable 'plug_name' [-Wunused-variable]
820 | const char *plug_name;
| ^~~~~~~~~
lv_audio.c: In function 'audio_band_total':
lv_audio.c:118:13: warning: unused variable 'i' [-Wunused-variable]
118 | int i;
| ^
lv_audio.c: In function 'audio_band_energy':
lv_audio.c:132:13: warning: unused variable 'i' [-Wunused-variable]
132 | int i;
| ^
lv_audio.c: In function 'visual_audio_analyze':
lv_audio.c:213:19: warning: unused variable 'y' [-Wunused-variable]
213 | int i, j, y;
| ^
lv_audio.c:213:16: warning: unused variable 'j' [-Wunused-variable]
213 | int i, j, y;
| ^
lv_audio.c:213:13: warning: unused variable 'i' [-Wunused-variable]
213 | int i, j, y;
| ^
lv_audio.c:212:16: warning: unused variable 'scale' [-Wunused-variable]
212 | double scale;
| ^~~~~
lv_audio.c:210:15: warning: unused variable 'temp_audio' [-Wunused-variable]
210 | float temp_audio[2][512];
| ^~~~~~~~~~
lv_audio.c:209:15: warning: unused variable 'temp_out' [-Wunused-variable]
209 | float temp_out[256];
| ^~~~~~~~
lv_audio.c: In function 'visual_audio_get_spectrum_multiplied':
lv_audio.c:552:13: warning: unused variable 'i' [-Wunused-variable]
552 | int i;
| ^
lv_audio.c: In function 'visual_audio_get_spectrum_for_sample_multiplied':
lv_audio.c:594:13: warning: unused variable 'i' [-Wunused-variable]
594 | int i;
| ^
lv_audio.c: At top level:
lv_audio.c:129:12: warning: 'audio_band_energy' defined but not used [-Wunused-function]
129 | static int audio_band_energy (VisAudio *audio, int band, int length)
| ^~~~~~~~~~~~~~~~~
lv_audio.c:115:12: warning: 'audio_band_total' defined but not used [-Wunused-function]
115 | static int audio_band_total (VisAudio *audio, int begin, int end)
| ^~~~~~~~~~~~~~~~
lv_audio.c: In function 'transform_format_buffer_from_float':
lv_audio.c:1111:20: warning: 'signedcorr' is used uninitialized [-Wuninitialized]
1111 | signedcorr += byte_max_numeric (size) / 2;
| ^~
lv_audio.c:1108:13: note: 'signedcorr' was declared here
1108 | int signedcorr;
| ^~~~~~~~~~
lv_video.c: In function 'visual_video_fill_color':
lv_video.c:1704:22: warning: unused variable 'rect' [-Wunused-variable]
1704 | VisRectangle rect;
| ^~~~
lv_video.c: In function 'visual_video_fill_color_rectangle':
lv_video.c:1766:1: warning: label 'out' defined but not used [-Wunused-label]
1766 | out:
| ^~~
lv_video.c: In function 'bgr_to_rgb32':
lv_video.c:2715:13: warning: unused variable 'i' [-Wunused-variable]
2715 | int i = 0;
| ^
lv_video.c: In function 'scale_bilinear_8':
lv_video.c:3168:53: warning: unused variable 'b' [-Wunused-variable]
3168 | uint8_t cul, cll, cur, clr, b;
| ^
lv_video.c: In function 'scale_bilinear_16':
lv_video.c:3231:34: warning: unused variable 'b3' [-Wunused-variable]
3231 | uint32_t b3, b2, b1, b0; /* fixed point 16.16 [0,255[ */
| ^~
lv_video.c: In function 'scale_bilinear_24':
lv_video.c:3306:34: warning: unused variable 'b3' [-Wunused-variable]
3306 | uint32_t b3, b2, b1, b0; /* fixed point 16.16 [0,255[ */
| ^~It would be good to clean all those warnings as well. Please let me know if you want above patches as PRs. |
|
Summary stats about compile time warnings [tkloczko@devel-g2v SPECS]$ rpmbuild -ba --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
39 -Wunused-variable
33 -Wunused-function
12 -Wunused-result
12 -Wreturn-type
2 -Wuninitialized
2 -Wpointer-to-int-cast
2 -Wint-to-pointer-cast
1 -Wunused-label
1 -Wparenthesesand it is yet another small automake issue examples/Makefile.am:5: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
libvisual/Makefile.am:29: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')Here is patch for that --- a/libvisual/Makefile.am
+++ b/libvisual/Makefile.am
@@ -17,16 +17,14 @@
lib_LTLIBRARIES = libvisual-@[email protected]
-DEFS = @DEFS@
-
-LIBS += -L. -L$(libdir) $(LV_THREAD_LIBS) @LTLIBINTL@
+LIBS += $(LV_THREAD_LIBS) $(LTLIBINTL)
PLUGPATH = $(libdir)/libvisual
AM_CFLAGS = -DPLUGPATH="\"$(LIBVISUAL_PLUGINS_BASE_DIR)\"" \
$(LV_THREAD_CFLAGS)
-INCLUDES = -I$(top_srcdir) -I$(top_srcdir)/libvisual \
+AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/libvisual \
-I$(top_builddir) -I$(top_builddir)/libvisual
libvisual_@LIBVISUAL_VERSION_SUFFIX@_la_LDFLAGS = -export-dynamic -no-undefined
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -1,12 +1,10 @@
## Process this file with automake to produce Makefile.in
-DEFS = @DEFS@
-
-INCLUDES = -I$(top_srcdir) -I$(top_srcdir)/examples -I$(top_builddir)
+AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/examples -I$(top_builddir)
AM_CFLAGS = $(SDL_CFLAGS) $(VISUAL_CFLAGS)
-noinst_PROGRAMS = @EXAMPLES@
+noinst_PROGRAMS = $(EXAMPLES)
EXTRA_PROGRAMS = simplesdl morphsdl
|
|
@kloczek speaking for myself, I welcome bug reports but not in unrelated closed tickets and five things at once and all mixed together. This is not proper bug reporting and it's not clean to-the-point pull requests either. Just dumping a pile of stuff is not very respectful, please reflect and reconsider your approach. Thank you. CC @kaixiong |
|
@kloczek definitely consider splitting this out into separate PRs, one for each issue. I find myself wondering if |
|
OK will do that 👍 |
|
Hmm .. just found that on mater everything is already switched to cmake so there nothing what it can be submitted 🤔 |
|
@kloczek that would be the |
|
PS: There will be a release 0.4.2 off of that in the near future. |
|
On the plus side, it's freed up your brain-space to look at new things :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like tar ball with libvisual provided on https://github.com/Libvisual/libvisual/releases are not the same as https://sourceforge.net/projects/libvisual/files/libvisual/libvisual-0.4.0/ which is a bit confusing which one are correct.
Additionally https://github.com/Libvisual/libvisual/archive/libvisual-0.4.0.tar.gz soes not contain libvisual tree but combined libvisual and libvisual-plugins packed in libvisual-libvisual-0.4.0/ directory.
Is it possible to regenerate those tar balls?
May I ask when you are planning to release 0.5.0?
PS. Please make sure that on 0.5.0 release dist tar balls will be generated correctly :)
The text was updated successfully, but these errors were encountered: