sc: move SheetViewManager into own header file, describe methods.

No other functional change was made, just simplification.

Change-Id: I9d34f1525470f6517b315be48f519f6a6e1b62f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189857
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <[email protected]>
(cherry picked from commit eb514bd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191084
Tested-by: Jenkins CollaboraOffice <[email protected]>
Reviewed-by: Miklos Vajna <[email protected]>

Author: quikee

sc/inc/SheetView.hxx

@@ -8,8 +8,6 @@
  */
 
 #pragma once
-#include <vector>
-#include "SheetViewTypes.hxx"
 #include "types.hxx"
 
 class ScTable;
@@ -36,26 +34,6 @@ public:
     /** A sheet view is valid if the pointer to the table is set */
     bool isValid() const;
 };
-
-/** Manager and the holder of the sheet views for a sheet. */
-class SheetViewManager
-{
-private:
-    std::vector<SheetView> maViews;
-
-public:
-    SheetViewManager();
-
-    /** Creates a new sheet view. */
-    SheetViewID create(ScTable* pSheetViewTable);
-
-    /** Returns a sheet view for the ID. */
-    SheetView get(SheetViewID nID) const;
-    bool isEmpty() const { return maViews.empty(); }
-    bool remove(SheetViewID nID);
-    std::vector<SheetView> const& getSheetViews() const { return maViews; }
-    SheetViewID getNextSheetView(SheetViewID nID);
-};
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

sc/inc/SheetViewManager.hxx

@@ -0,0 +1,50 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+#include "SheetViewTypes.hxx"
+#include "SheetView.hxx"
+#include "types.hxx"
+
+#include <vector>
+
+class ScTable;
+
+namespace sc
+{
+/** Manager and the holder of the sheet views for a sheet. */
+class SheetViewManager
+{
+private:
+    std::vector<SheetView> maViews;
+
+public:
+    SheetViewManager();
+
+    /** Creates a new sheet view. */
+    SheetViewID create(ScTable* pSheetViewTable);
+
+    /** Returns a sheet view for the ID. */
+    SheetView get(SheetViewID nID) const;
+
+    /** True if there are no sheet views. */
+    bool isEmpty() const { return maViews.empty(); }
+
+    /** Remove the sheet view with the ID. True if successful. */
+    bool remove(SheetViewID nID);
+
+    /** Return the list of sheet views. */
+    std::vector<SheetView> const& getSheetViews() const { return maViews; }
+
+    /** Calculate the next sheet view ID from the current ID. */
+    SheetViewID getNextSheetView(SheetViewID nID);
+};
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

sc/qa/unit/tiledrendering/SheetViewTest.cxx

@@ -17,6 +17,7 @@
 #include <sctestviewcallback.hxx>
 #include <docuno.hxx>
 #include <SheetView.hxx>
+#include <SheetViewManager.hxx>
 
 using namespace css;
 

sc/source/core/data/SheetViewManager.cxx

@@ -7,7 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include <SheetView.hxx>
+#include <SheetViewManager.hxx>
 #include <table.hxx>
 
 namespace sc

sc/source/core/data/document10.cxx

@@ -28,7 +28,7 @@
 #include <docsh.hxx>
 #include <bcaslot.hxx>
 #include <broadcast.hxx>
-#include <SheetView.hxx>
+#include <SheetViewManager.hxx>
 
 // Add totally brand-new methods to this source file.
 

sc/source/core/data/table1.cxx

@@ -53,7 +53,7 @@
 #include <rowheightcontext.hxx>
 #include <compressedarray.hxx>
 #include <tabvwsh.hxx>
-#include <SheetView.hxx>
+#include <SheetViewManager.hxx>
 #include <vcl/svapp.hxx>
 
 #include <formula/vectortoken.hxx>

sc/source/ui/view/viewfun3.cxx

@@ -63,7 +63,7 @@
 #include <cliputil.hxx>
 #include <clipoptions.hxx>
 #include <gridwin.hxx>
-#include <SheetView.hxx>
+#include <SheetViewManager.hxx>
 #include <uiitems.hxx>
 #include <com/sun/star/util/XCloneable.hpp>
 

sc/source/ui/view/viewfunc.cxx

@@ -77,7 +77,7 @@
 #include <columnspanset.hxx>
 #include <stringutil.hxx>
 #include <SparklineList.hxx>
-#include <SheetView.hxx>
+#include <SheetViewManager.hxx>
 
 #include <memory>