ActiveDirectory.config.php incorrectly parsed

[abaldoni]

[X]: This is a bug and not a question.

[X]: I understand that the best way to resolve this issue is to solve it and propose a Pull Request.

Describe the bug**

The ActiveDirectory.config.php format is as follows:

return [
    'settings' => [
            'domain.controllers' => 'list,of,dcs',
            'port' => 389,
            'username' => 'username',
...

This file is parsed as expected: this has been verified by

var_dump(Configuration::Instance()->File(ActiveDirectoryConfigKeys::CONFIG_ID))

The ActiveDirectoryConfigKeys.php however specifies that all settings should be inside a 'activedirectory' section:

    public const DOMAIN_CONTROLLERS = [
        'key' => 'domain.controllers',
        'type' => 'string',
        'default' => '',
        'label' => 'Domain Controllers',
        'description' => 'Comma separated list of domain controllers',
        'section' => 'activedirectory'
    ];

since in ActiveDirectoryOptions.php configuration keys are retrieved by:

$this->GetConfig(ActiveDirectoryConfigKeys::DOMAIN_CONTROLLERS)

If ActiveDirectory.config.php is changed as follows

return [
    'settings' => [
         'activedirectory' => [
            'domain.controllers' => 'list,of,dcs',
            'port' => 389,
            'username' => 'username',
...

it will be parsed without errors but the result will be empty:

object(ConfigurationFile)#174 (2) { ["_values":"ConfigurationFile":private]=> array(0) { } 
	["_configKeysClass":"ConfigurationFile":private]=> string(25) "ActiveDirectoryConfigKeys" }

Specifications

• LibreBooking version: 4.0.0

[soumik-com]

Adding the existing bug reports related to this so that we can reference them at once.

• [BUG] AD/LDAP Authentication Bug #824

• PHP libraries aren't fully embracing the new config files formatting #854

• Error when selecting LDAP or ActiveDirectory plugin in the Plugins tab #782

[dijoux]

As a workaround i added $configDef['section'] = null; to ActiveDirectoryOptions.php like following :

    private function GetConfig($configDef, $converter = null)
    {
        $configDef['section'] = null;
        return Configuration::Instance()->File(ActiveDirectoryConfigKeys::CONFIG_ID)->GetKey($configDef, $converter);
    }

[vittore]

I confirm that's works fine.

v.

[github-actions]

This issue was marked stale because it has been open 60 days with no
activity. Please remove the stale label or comment on this issue. Otherwise,
it will be closed in 15 days.

As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.md

How to keep this issue open:

• If you are still experiencing this issue and are willing to
  investigate a fix, please comment and let us know.
• If you (or someone else) can propose a pull request with a
  solution, that would be fantastic.
• Any significant update or active discussion indicating progress
  will also prevent closure.

We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.

This is documented in CONTRIBUTING.md

https://github.com/LibreBooking/app/blob/develop/CONTRIBUTING.md