Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple values as cors_origin #5198

Closed
Nothing4You opened this issue Nov 12, 2024 · 0 comments
Closed

Allow multiple values as cors_origin #5198

Nothing4You opened this issue Nov 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Nothing4You
Copy link
Collaborator

Nothing4You commented Nov 12, 2024 •
edited
Loading

I mentioned this in #5185 already, I don't think it makes much sense to only allow a single value for CORS-allowed domains. For example, if you'd want to allow people to use the official photon deployment at https://phtn.app/ and also the official voyager deployment at https://vger.app/ but no other domains you'll need to allow both of them. The current implementation does not allow for that.

Originally posted by @Nothing4You in #5194 (comment)
@Nothing4You Nothing4You changed the title I mentioned this in #5185 already, I don't think it makes much sense to only allow a single value for CORS-allowed domains. For example, if you'd want to allow people to use the official photon deployment at https://phtn.app/ and also the official voyager deployment at https://vger.app/ but no other domains you'll need to allow both of them. The current implementation does not allow for that. Allow multiple values as cors_origin Nov 12, 2024
@Nutomic Nutomic added the enhancement New feature or request label Jan 24, 2025
Nutomic added a commit that referenced this issue Jan 24, 2025
@Nutomic
Allow setting multiple values for cors_origin (fixes #5198)
f41e910
Nutomic added a commit that referenced this issue Jan 29, 2025
@Nutomic
Allow setting multiple values for cors_origin (fixes #5198) (#5353)
5bda04f 
* Allow setting multiple values for cors_origin (fixes #5198)

* fmt

* mention env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nutomic @Nothing4You