Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrice Product vs glm vs Scilab #3

Open
Lecrapouille opened this issue Feb 7, 2021 · 0 comments
Open

Matrice Product vs glm vs Scilab #3

Lecrapouille opened this issue Feb 7, 2021 · 0 comments

Comments

@Lecrapouille
Copy link
Owner

OpenGL convention: column vector. For example Translation:
| 1 0 0 Tx | | x |
| 0 1 0 Ty | * | y |
| 0 0 1 Tz | | z |

  • OpenGL and glm store transposed matrices (=> column major) but keep follow the M . x convention instead of x' . M' therefore their * is inversed and on my side I have to follow x' . M since I follow scilab matrix product.
  • I would remove the transposed computation inside Transform.hpp and transformable.hpp + camera.cpp
  • In addition vector * vector should be like Scilab: dot product + check about dimensions. The * is in fact a component product.
  • I would make Vector be column or row: template <T, n, m> vector + check if n or m are 1. => ColumnVecor<T, n> = Vector<T, n, 1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant