Commit 80b74fa
authored
fix: address Certora audit findings for Slashing UX Improvements (#1693)
**Motivation:**
Address findings from the Certora audit of EigenLayer Slashing UX
Improvements. This branch consolidates fixes for low-severity findings
(L-01) and informational findings (I-01 through I-05) across
AllocationManager and ProtocolRegistry contracts.
**Modifications:**
### AllocationManager Fixes
**L-01: State inconsistency fixes**
- Update `slasher` field immediately when `instantEffectBlock=true` to
prevent stale storage (#1687)
- Update `delay` and `isSet` fields immediately for newly registered
operators to ensure storage consistency (#1688)
**I-01: Re-proposing same pending slasher is now a no-op** (#1689)
- Added check in `_updateSlasher()` to skip processing if the proposed
slasher is already pending
- Prevents accidentally restarting the delay countdown
**I-02: Add NatSpec documentation for getSlasher/getPendingSlasher**
(#1689)
- Document that these functions return `address(0)`/`0` for non-existent
operator sets
**I-03: Add separate SLASHER_CONFIGURATION_DELAY constant** (#1689)
- New immutable allows independent configuration of slasher delay in
future upgrades
- Currently set to same value as `ALLOCATION_CONFIGURATION_DELAY`
**I-05: Add gas warning documentation for migrateSlashers** (#1689)
- Document O(appointees) gas cost per operator set
- Warn about potential block gas limit issues with large appointee sets
### ProtocolRegistry Fixes
**I-01: ship() lacks validation** (#1690)
- Added array length validation for addresses, configs, and names
- Added zero address validation with new `ArrayLengthMismatch()` and
`InputAddressZero()` errors
**I-02: Orphaned configs on name overwrite** (#1690)
- Delete old address's `DeploymentConfig` when re-shipping a name with a
new address
- Added `DeploymentConfigDeleted(address)` event
**I-03: configure() for unshipped addresses** (#1690)
- Updated `configure` to require a name parameter
- Added validation that address must be a shipped deployment
**I-04: Fix misleading NatSpec** (#1690)
- Clarified `ship()` behavior when re-shipping names
- Updated `configure()` NatSpec for address requirements
**I-05: Document pauseAll blocking** (#1690)
- Added warning that `pauseAll()` reverts if ANY pausable deployment
fails
### Other Changes
- v1.9.0 upgrade script fixes for testnet deploy (#1677)
- Added Claude skills for development workflow (#1686)
**Result:**
- Audit fixes completeFile tree
33 files changed
+2437
-98
lines changed- .claude/skills
- audit-extractor
- integration-test-writer
- interface-lint
- unit-test-writer
- audits
- docs/core
- pkg/bindings
- AllocationManagerStorage
- AllocationManagerView
- AllocationManager
- CrossChainRegistry
- DelegationManager
- IAllocationManager
- IProtocolRegistry
- KeyRegistrar
- ProtocolRegistryStorage
- ProtocolRegistry
- RewardsCoordinator
- StrategyManager
- script/releases
- v1.9.0-slashing-ux-destination
- v1.9.0-slashing-ux
- src
- contracts
- core
- storage
- interfaces
- test
- harnesses
- unit
33 files changed
+2437
-98
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
0 commit comments