refactor: remove v prefix from SemVerMixin (#1385)

**Motivation:**

Slashing was deployed with using a `v` prefix, thus we're simply going
to drop the prefix moving forward.

**Modifications:**

Prefix removed, and tests updated.

**Result:**

SemVerMixin no longer requires a `v` prefix.

Author: 0xClandestine

src/contracts/interfaces/IRewardsCoordinator.sol

@@ -258,7 +258,7 @@ interface IRewardsCoordinatorTypes {
      * @param MAX_RETROACTIVE_LENGTH The maximum retroactive length of a rewards submission
      * @param MAX_FUTURE_LENGTH The maximum future length of a rewards submission
      * @param GENESIS_REWARDS_TIMESTAMP The timestamp at which rewards are first calculated
-     * @param version The semantic version of the contract (e.g. "v1.2.3")
+     * @param version The semantic version of the contract (e.g. "1.2.3")
      * @dev Needed to avoid stack-too-deep errors
      */
     struct RewardsCoordinatorConstructorParams {

src/contracts/interfaces/ISemVerMixin.sol

@@ -6,6 +6,6 @@ pragma solidity ^0.8.0;
 /// @dev Follows SemVer 2.0.0 specification (https://semver.org/)
 interface ISemVerMixin {
     /// @notice Returns the semantic version string of the contract.
-    /// @return The version string in SemVer format (e.g., "v1.1.1")
+    /// @return The version string in SemVer format (e.g., "1.1.1")
     function version() external view returns (string memory);
 }

src/contracts/mixins/SemVerMixin.sol

@@ -11,12 +11,12 @@ abstract contract SemVerMixin is ISemVerMixin {
     using ShortStringsUpgradeable for *;
 
     /// @notice The semantic version string for this contract, stored as a ShortString for gas efficiency.
-    /// @dev Follows SemVer 2.0.0 specification (https://semver.org/). Prefixed with 'v' (e.g., "v1.2.3").
+    /// @dev Follows SemVer 2.0.0 specification (https://semver.org/).
     ShortString internal immutable _VERSION;
 
     /// @notice Initializes the contract with a semantic version string.
-    /// @param _version The SemVer-formatted version string (e.g., "v1.2.3")
-    /// @dev Version should follow SemVer 2.0.0 format with 'v' prefix: vMAJOR.MINOR.PATCH
+    /// @param _version The SemVer-formatted version string (e.g., "1.2.3")
+    /// @dev Version should follow SemVer 2.0.0 format: MAJOR.MINOR.PATCH
     constructor(
         string memory _version
     ) {
@@ -29,10 +29,10 @@ abstract contract SemVerMixin is ISemVerMixin {
     }
 
     /// @notice Returns the major version of the contract.
-    /// @dev Supports single digit major versions (e.g., "v1" for version "v1.2.3")
-    /// @return The major version string (e.g., "v1" for version "v1.2.3")
+    /// @dev Supports single digit major versions (e.g., "1" for version "1.2.3")
+    /// @return The major version string (e.g., "1" for version "1.2.3")
     function _majorVersion() internal view returns (string memory) {
         bytes memory v = bytes(_VERSION.toString());
-        return string(bytes.concat(v[0], v[1]));
+        return string(abi.encodePacked(v[0]));
     }
 }

src/contracts/mixins/SignatureUtilsMixin.sol

@@ -21,7 +21,7 @@ abstract contract SignatureUtilsMixin is ISignatureUtilsMixin, SemVerMixin {
     using SignatureCheckerUpgradeable for address;
 
     /// @notice Initializes the contract with a semantic version string.
-    /// @param _version The SemVer-formatted version string (e.g., "v1.1.1") to use for this contract's domain separator.
+    /// @param _version The SemVer-formatted version string (e.g., "1.1.1") to use for this contract's domain separator.
     /// @dev Version should follow SemVer 2.0.0 format with 'v' prefix: vMAJOR.MINOR.PATCH.
     ///      Only the major version component is used in the domain separator to maintain signature compatibility
     ///      across minor and patch version updates.

src/test/harnesses/AllocationManagerHarness.sol

@@ -13,7 +13,7 @@ contract AllocationManagerHarness is AllocationManager {
         uint32 _DEALLOCATION_DELAY,
         uint32 _ALLOCATION_CONFIGURATION_DELAY
     )
-        AllocationManager(_delegation, _pauserRegistry, _permissionController, _DEALLOCATION_DELAY, _ALLOCATION_CONFIGURATION_DELAY, "v9.9.9")
+        AllocationManager(_delegation, _pauserRegistry, _permissionController, _DEALLOCATION_DELAY, _ALLOCATION_CONFIGURATION_DELAY, "9.9.9")
     {}
 
     function deallocationQueueAtIndex(address operator, IStrategy strategy, uint index) external view returns (bytes32) {

src/test/harnesses/DelegationManagerHarness.sol

@@ -20,7 +20,7 @@ contract DelegationManagerHarness is DelegationManager {
             _pauserRegistry,
             _permissionController,
             _MIN_WITHDRAWAL_DELAY,
-            "v9.9.9"
+            "9.9.9"
         )
     {}
 

src/test/integration/IntegrationDeployer.t.sol

@@ -41,7 +41,7 @@ abstract contract IntegrationDeployer is ExistingDeploymentParser {
     bool isUpgraded;
     uint mainnetForkBlock = 21_616_692; // Post Protocol Council upgrade
 
-    string version = "v9.9.9";
+    string version = "9.9.9";
 
     // Beacon chain genesis time when running locally
     // Multiple of 12 for sanity's sake
@@ -352,14 +352,14 @@ abstract contract IntegrationDeployer is ExistingDeploymentParser {
         );
         avsDirectoryImplementation = new AVSDirectory(delegationManager, eigenLayerPauserReg, version);
         eigenPodManagerImplementation =
-            new EigenPodManager(DEPOSIT_CONTRACT, eigenPodBeacon, delegationManager, eigenLayerPauserReg, "v9.9.9");
-        strategyFactoryImplementation = new StrategyFactory(strategyManager, eigenLayerPauserReg, "v9.9.9");
+            new EigenPodManager(DEPOSIT_CONTRACT, eigenPodBeacon, delegationManager, eigenLayerPauserReg, "9.9.9");
+        strategyFactoryImplementation = new StrategyFactory(strategyManager, eigenLayerPauserReg, "9.9.9");
         slashingWithdrawalRouterImplementation =
-            new SlashingWithdrawalRouter(allocationManager, strategyManager, eigenLayerPauserReg, "v9.9.9");
+            new SlashingWithdrawalRouter(allocationManager, strategyManager, eigenLayerPauserReg, "9.9.9");
 
         // Beacon implementations
-        eigenPodImplementation = new EigenPod(DEPOSIT_CONTRACT, eigenPodManager, BEACON_GENESIS_TIME, "v9.9.9");
-        baseStrategyImplementation = new StrategyBase(strategyManager, eigenLayerPauserReg, "v9.9.9");
+        eigenPodImplementation = new EigenPod(DEPOSIT_CONTRACT, eigenPodManager, BEACON_GENESIS_TIME, "9.9.9");
+        baseStrategyImplementation = new StrategyBase(strategyManager, eigenLayerPauserReg, "9.9.9");
 
         // Pre-longtail StrategyBaseTVLLimits implementation
         // TODO - need to update ExistingDeploymentParser

src/test/integration/tests/eigenpod/SlashBC_OneBCSF.t.sol

@@ -34,7 +34,7 @@ contract Integration_SlashBC_OneBCSF is IntegrationCheckUtils {
     function _init() internal override {
         // 1. etch a new implementation to set staker's beaconChainSlashingFactor to 1
         EigenPodManagerWrapper eigenPodManagerWrapper =
-            new EigenPodManagerWrapper(DEPOSIT_CONTRACT, eigenPodBeacon, delegationManager, eigenLayerPauserReg, "v9.9.9");
+            new EigenPodManagerWrapper(DEPOSIT_CONTRACT, eigenPodBeacon, delegationManager, eigenLayerPauserReg, "9.9.9");
         address targetAddr = address(eigenPodManagerImplementation);
         cheats.etch(targetAddr, address(eigenPodManagerWrapper).code);
 

src/test/mocks/EigenPodMock.sol

@@ -6,7 +6,7 @@ import "../../contracts/interfaces/IEigenPod.sol";
 import "../../contracts/mixins/SemVerMixin.sol";
 
 contract EigenPodMock is IEigenPod, SemVerMixin, Test {
-    constructor() SemVerMixin("v9.9.9") {}
+    constructor() SemVerMixin("9.9.9") {}
 
     function nonBeaconChainETHBalanceWei() external view returns (uint) {}
 

src/test/unit/AVSDirectoryUnit.t.sol

@@ -36,7 +36,7 @@ contract AVSDirectoryUnitTests is EigenLayerUnitTestSetup, IAVSDirectoryEvents,
         avsd = AVSDirectory(
             address(
                 new TransparentUpgradeableProxy(
-                    address(new AVSDirectory(IDelegationManager(delegationManager), pauserRegistry, "v9.9.9")),
+                    address(new AVSDirectory(IDelegationManager(delegationManager), pauserRegistry, "9.9.9")),
                     address(eigenLayerProxyAdmin),
                     abi.encodeWithSelector(
                         AVSDirectory.initialize.selector,
@@ -51,7 +51,7 @@ contract AVSDirectoryUnitTests is EigenLayerUnitTestSetup, IAVSDirectoryEvents,
         bytes memory v = bytes(avsd.version());
         bytes32 expectedDomainSeparator = keccak256(
             abi.encode(
-                EIP712_DOMAIN_TYPEHASH, keccak256(bytes("EigenLayer")), keccak256(bytes.concat(v[0], v[1])), block.chainid, address(avsd)
+                EIP712_DOMAIN_TYPEHASH, keccak256(bytes("EigenLayer")), keccak256(abi.encodePacked(v[0])), block.chainid, address(avsd)
             )
         );