Merge pull request #1 from davidgurnsey/master

LaurentGoderre · web-flow · commit b927ecdd9618 · 2021-07-09T22:19:58.000-04:00
change windows behavior to not fire on handled exs
diff --git a/src/segfault-handler.cpp b/src/segfault-handler.cpp
@@ -326,7 +326,7 @@ NAN_METHOD(RegisterHandler) {
   }
 
   #ifdef _WIN32
-    AddVectoredExceptionHandler(1, segfault_handler);
+    SetUnhandledExceptionFilter(segfault_handler);
   #else
     struct sigaction sa;
     memset(&sa, 0, sizeof(struct sigaction));

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ NAN_METHOD(RegisterHandler) {`
`326`	`326`	`}`
`327`	`327`
`328`	`328`	`#ifdef _WIN32`
`329`		`- AddVectoredExceptionHandler(1, segfault_handler);`
	`329`	`+ SetUnhandledExceptionFilter(segfault_handler);`
`330`	`330`	`#else`
`331`	`331`	`struct sigaction sa;`
`332`	`332`	`memset(&sa, 0, sizeof(struct sigaction));`