Fishing Refactor - To Do List and Discussion

[paladindamarus]

All:

I'm looking at working on rebuilding fishing on the base LSB using a combination of data I have from Horizon along with some sourced information. I've got some workings on my local to move the primary fishing logic into Lua while leaving the C++ core to handle the packeting systems, etc. Currently, I'm working on collecting data for fishing areas and confirming some of the logic (based on captures in that discord.

Below is an EARLY draft of the to-do list. I'm hoping I can get some feedback on the processes I should be following before I starting running with this. I learned a lot from doing the Fishing Contest, but I don't want to submit another single monster PR like I did with that one. Hopefully I can get some feedback and guidance, and if this is an item of interest, some feedback on the best ways to approach certain things.

The list so far:

Packet System
    [ ] C -> S 0x001S, action 14
        Player uses /fish
        Client checks validity and sends packet
    [ ] S -> C
        [ ] Unsuccessful fishing attempt
            [ ] 0x0036 response message packet
            [ ] 0x0052 event release packet
        [ ] Successul attempt
            [ ] Set client server status to 56, sent in next char update
    [ ] (More to add...)

Base system
    [ ] Insert packet verification system in core
        [ ] Confirm player location based on server data rather than cli
        [ ] Check equipment set at start of fishing event, ensure the sa
        [ ] Check player position for proximity to legimite area
        [ ] Rate-limit fishing (time between /fish commands)

    [ ] Move zone area data into Lua
	    [ ] Capture legitimate fishing areas with sets of coordinates for area proximity
	    [ ] Associate fishing pools to areas
            [ ] Implement option for shared pools (ref: https://forum.square-enix.com/ffxi/threads/40708-Fishing-System-Renovation)
        [ ] Pool depletion status (use global lua table, or zone variable?)

    [ ] Implement fishing catch logic in Lua
        [ ] Skill Augmentations
            [ ] (Lua) Player: Moghancements
        [ ] (Lua) Rod qualities
        [ ] (Lua) Catch skills
        [ ] (Lua->Core->DB) Stats tracking (quest, etc)
        [ ] (Lua) Fish selection
        	
    [ ] Add fish pool data and tracking mechanism in Lua

Data Verification
    [ ] Rod data verification
    [ ] Fish data verification

[cocosolos]

Re: fishing pools

These were changed in the fishing update in 2013. If you're implementing shared pools, it should be behind a setting.

Fish Numbers per Area
Pre-adjustment
The number of fish inhabiting a single area was shared between characters
Post-adjustment
There are no restrictions on the number of fish that can inhabit an area. However, fishing fatigue restrictions remain the same. Once an angler has reeled in a certain amount of fish, he cannot reel in any more for the remainder of the day.

https://forum.square-enix.com/ffxi/threads/40708-Fishing-System-Renovation

[paladindamarus]

Good to note, thank you!