From 0313a0e0160f0044f9487cd85a1e4cddf96cfc58 Mon Sep 17 00:00:00 2001 From: Leonardo Date: Mon, 10 Feb 2025 13:40:27 -0300 Subject: [PATCH] refactor: remove unused constructors and commented code in Analytic and AnalyticMapper classes --- .../qualitylabpro/entities/Analytic.java | 40 ------------------- .../utils/mappers/AnalyticMapper.java | 21 ---------- 2 files changed, 61 deletions(-) diff --git a/src/main/java/leonardo/labutilities/qualitylabpro/entities/Analytic.java b/src/main/java/leonardo/labutilities/qualitylabpro/entities/Analytic.java index 568d698..1983598 100644 --- a/src/main/java/leonardo/labutilities/qualitylabpro/entities/Analytic.java +++ b/src/main/java/leonardo/labutilities/qualitylabpro/entities/Analytic.java @@ -35,8 +35,6 @@ public class Analytic extends RepresentationModel { private String unitValue; private String rules; private String description; - // @Transient - // private RulesValidatorComponent rulesValidatorComponent; public Analytic() {} @@ -44,42 +42,4 @@ public Analytic(AnalyticsDTO values) { AnalyticMapper.toNewEntity(values); } - // public Analytic(AnalyticsDTO values, RulesValidatorComponent rulesValidatorComponent) { - // AnalyticMapper.toEntity(values, rulesValidatorComponent); - // } - - // public Analytic(Long id, LocalDateTime date, String levelLot, String testLot, String name, - // String level, double value, double mean, double sd, String unitValue, String rules, - // String description, RulesValidatorComponent rulesValidatorComponent) { - // this.id = id; - // this.date = date; - // this.levelLot = levelLot; - // this.testLot = testLot; - // this.name = name; - // this.level = level; - // this.value = value; - // this.mean = mean; - // this.sd = sd; - // this.unitValue = unitValue; - // this.rules = rules; - // this.description = description; - // this.rulesValidatorComponent = rulesValidatorComponent; - // } - - // public Analytic(AnalyticsDTO values, RulesValidatorComponent rulesValidatorComponent) { - // this.date = values.date(); - // this.levelLot = values.level_lot(); - // this.testLot = values.test_lot(); - // this.name = values.name(); - // this.level = values.level(); - // this.value = values.value(); - // this.mean = values.mean(); - // this.sd = values.sd(); - // this.unitValue = values.unit_value(); - // this.rulesValidatorComponent = rulesValidatorComponent; - // rulesValidatorComponent.validator(this.value, this.mean, this.sd); - // this.rules = rulesValidatorComponent.getRules(); - // this.description = rulesValidatorComponent.getDescription(); - // } } - diff --git a/src/main/java/leonardo/labutilities/qualitylabpro/utils/mappers/AnalyticMapper.java b/src/main/java/leonardo/labutilities/qualitylabpro/utils/mappers/AnalyticMapper.java index 6cb4cb0..06e9348 100644 --- a/src/main/java/leonardo/labutilities/qualitylabpro/utils/mappers/AnalyticMapper.java +++ b/src/main/java/leonardo/labutilities/qualitylabpro/utils/mappers/AnalyticMapper.java @@ -12,27 +12,6 @@ private AnalyticMapper() { private static RulesValidatorComponent rulesValidatorComponent = new RulesValidatorComponent(); - // public static Analytic toEntity(AnalyticsDTO analyticsDTO, - // RulesValidatorComponent rulesValidatorComponent) { - // Analytic analytic = new Analytic(); - // analytic.setId(analyticsDTO.id()); - // analytic.setDate(analyticsDTO.date()); - // analytic.setLevelLot(analyticsDTO.level_lot()); - // analytic.setTestLot(analyticsDTO.test_lot()); - // analytic.setName(analyticsDTO.name()); - // analytic.setLevel(analyticsDTO.level()); - // analytic.setValue(analyticsDTO.value()); - // analytic.setMean(analyticsDTO.mean()); - // analytic.setSd(analyticsDTO.sd()); - // analytic.setUnitValue(analyticsDTO.unit_value()); - // rulesValidatorComponent.validator(analyticsDTO.value(), analyticsDTO.mean(), - // analyticsDTO.sd()); - // analytic.setRules(rulesValidatorComponent.getRules()); - // analytic.setDescription(rulesValidatorComponent.getDescription()); - - // return analytic; - // } - private static Analytic toEntityRulesValidator(AnalyticsDTO analyticsDTO) { Analytic analytic = new Analytic(); analytic.setId(analyticsDTO.id());