std::iterator deprecated in C++17 - error with -Werror with gcc 13.2.1

[nicolasaunai]

this code here:

SAMRAI/source/SAMRAI/hier/Box.h

Line 1472 in 11612bc

class BoxIterator : public std::iterator<std::random_access_iterator_tag, Index>

leads to

error: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Werror=deprecated-declarations] with gcc 13.2.1 (fedora 38)

See for instance this blog post

[nicolasaunai]

I also see that on gcc 12.3.1 actually, -Werror=deprecated-declarations

[rhornung67]

Hopefully this is helpful: https://stackoverflow.com/questions/43268146/why-is-stditerator-deprecated

[PhilipDeegan]

This is done and can be closed