Skip to content

Commit 976904b

Browse files
mreiderclaude
andcommitted
Fix Windows artifact filename for electron-updater metadata
Set NSIS artifactName to Purroxy-Setup-${version}.exe (no spaces) and update the release job's version.json and latest.yml generation to match, so electron-updater receives a working download path on Windows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent fa5b585 commit 976904b

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,15 +202,15 @@ jobs:
202202
- name: Generate version.json
203203
run: |
204204
VERSION="${GITHUB_REF#refs/tags/v}"
205-
echo "{\"version\":\"${VERSION}\",\"date\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"dmg\":\"Purroxy-${VERSION}-arm64.dmg\",\"exe\":\"Purroxy.Setup.${VERSION}.exe\",\"appimage\":\"Purroxy-${VERSION}.AppImage\"}" > artifacts/version.json
205+
echo "{\"version\":\"${VERSION}\",\"date\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"dmg\":\"Purroxy-${VERSION}-arm64.dmg\",\"exe\":\"Purroxy-Setup-${VERSION}.exe\",\"appimage\":\"Purroxy-${VERSION}.AppImage\"}" > artifacts/version.json
206206
207207
- name: Generate electron-updater metadata
208208
run: |
209209
VERSION="${GITHUB_REF#refs/tags/v}"
210210
DATE=$(date -u +%Y-%m-%dT%H:%M:%S.000Z)
211211
212212
DMG="artifacts/Purroxy-${VERSION}-arm64.dmg"
213-
EXE="artifacts/Purroxy.Setup.${VERSION}.exe"
213+
EXE="artifacts/Purroxy-Setup-${VERSION}.exe"
214214
APPIMAGE="artifacts/Purroxy-${VERSION}.AppImage"
215215
216216
gen_yml() {

electron-builder.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ mac:
1414
win:
1515
icon: resources/icon.png
1616
target: nsis
17+
artifactName: ${productName}-Setup-${version}.${ext}
1718
linux:
1819
category: Utility
1920
icon: resources/icon.png

0 commit comments

Comments
 (0)