We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug While gathering ROS parameters in ublox_gps/src/node.cpp the configuration for nmea does not include "version".
ublox_gps/src/node.cpp
nmea
To Reproduce Checkout the ros2 branch. https://github.com/KumarRobotics/ublox/blob/ros2/ublox_gps/src/node.cpp#L389
ros2
Steps to reproduce the behavior:
// NMEA parameters this->declare_parameter("nmea.set", false); this->declare_parameter("nmea.compat", false); this->declare_parameter("nmea.consider", false); this->declare_parameter("nmea.limit82", false); this->declare_parameter("nmea.high_prec", false); this->declare_parameter("nmea.filter.pos", false); this->declare_parameter("nmea.filter.msk_pos", false); this->declare_parameter("nmea.filter.time", false); this->declare_parameter("nmea.filter.date", false); this->declare_parameter("nmea.filter.sbas", false); this->declare_parameter("nmea.filter.track", false); this->declare_parameter("nmea.filter.gps_only", false); this->declare_parameter("nmea.gnssToFilter.gps", false); this->declare_parameter("nmea.gnssToFilter.sbas", false); this->declare_parameter("nmea.gnssToFilter.qzss", false); this->declare_parameter("nmea.gnssToFilter.glonass", false); this->declare_parameter("nmea.gnssToFilter.beidou", false);
nmea: set: false version: 65
Expected behavior I expect the version to be taken into consideration because it is required when nmea is set true.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered:
Same is valid for the two other parameters:
this->declare_parameter("nmea.num_sv", 30); this->declare_parameter("nmea.sv_numbering", 1);
Sorry, something went wrong.
No branches or pull requests
Describe the bug
While gathering ROS parameters in
ublox_gps/src/node.cpp
the configuration fornmea
does not include "version".To Reproduce
Checkout the
ros2
branch.https://github.com/KumarRobotics/ublox/blob/ros2/ublox_gps/src/node.cpp#L389
Steps to reproduce the behavior:
Around ~389:
Expected behavior
I expect the version to be taken into consideration because it is required when
nmea
is set true.Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: