Purpose of modes stack size checking in lexer

[KvanTTT]

Could you explain the purpose of modes stack size checking before popMode()?

kotlin-spec/grammar/src/main/antlr/KotlinLexer.g4

Line 44 in 091d421

RCURL: '}' { if (!_modeStack.isEmpty()) { popMode(); } };

Is this a workaround for more reliable error handling if the first open LCURL is missed?

Is this related to antlr/antlr4#2006

[petukhovv]

Yes, absolutely right. It's related to antlr/antlr4#2006.

Without this check, we encountered an EmptyStackException in the absence of an opening } and couldn't write the corresponding grammar tests.

Unfortunately, with this check, the grammar is language-dependent, so we hope that ANTLR will not fall hard in the future in this case, and that we can remove the empty stack check.

[wmeints]

I ran into this exact problem. Because it's language specific now, I can't use the lexer without modifying it, so it matches the generated C# code. I've worked around it, but I do hope they fix the problem in the future.

[mlynch]

Does anyone have an example of what changes they made to this line for their specific programming language? I'm using antlr_rust and a bit unsure how this line should be modified for this library.

[KvanTTT]

All targets have similar fields _modeStack and similar methods (isEmpty, popMode).

[KvanTTT]

mode_stack, pop_mode

[mlynch]

@KvanTTT thank you!!