Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clustering/rpc): add support for cert details #14050

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 24, 2024

Summary

KAG-6084
This PR follows #14046.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 24, 2024
@chronolaw chronolaw marked this pull request as ready for review December 24, 2024 13:20
Copy link
Member

@dndx dndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the spec file as well?

@chronolaw
Copy link
Contributor Author

Should we update the spec file as well?

No, we did not change rpc spec.

@ADD-SP ADD-SP merged commit 0ebc358 into master Dec 30, 2024
28 checks passed
@ADD-SP ADD-SP deleted the feat/add_dp_cert_details_in_rpc branch December 30, 2024 02:26
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-14050-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-14050-to-master-to-upstream
git checkout -b cherry-pick-14050-to-master-to-upstream
ancref=$(git merge-base 8e14a18c4d56bd726833ecf305c56fbf209ed943 477c37377d7ca59c5d617a1b0adcf2495c0cf2d5)
git cherry-pick -x $ancref..477c37377d7ca59c5d617a1b0adcf2495c0cf2d5

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants