close socket connection when websocket connect failed to avoid potential leak #14038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
chobits
approved these changes
Dec 19, 2024
ADD-SP
approved these changes
Dec 20, 2024
ProBrian
force-pushed
the
chore/ws_close
branch
from
f472617 to
7fecc42
Compare
chobits
reviewed
Dec 20, 2024
changelog/unreleased/kong/fix-potential-socket-connection-leak.yml
Outdated
Show resolved
Hide resolved
chobits
approved these changes
Dec 20, 2024
ADD-SP
reviewed
Dec 20, 2024
| @@ -0,0 +1,3 @@ | |||
| message: "Fix potential socket connection leak when websocket client connection fails" | |||
There was a problem hiding this comment.
Suggested change
| message: "Fix potential socket connection leak when websocket client connection fails" | |
| message: "Fixed potential connection leaks when the data plane failed to connect to the control plane. |
kikito
approved these changes
Dec 23, 2024
|
Successfully created cherry-pick PR for |
|
Manually cherry-pick: https://github.com/Kong/kong-ee/pull/11031 |
3 tasks
ADD-SP
pushed a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For websocket client, we should close socket connection by
websocket.client.close()when there's error onwebsocket.client.connect, becauseconnectfailure will leave an occupied socket. We should not rely on GC to release the socket connection.Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix https://konghq.atlassian.net/browse/KAG-5361