Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clustering): add no_broadcast_crud_event for dp status updating #13858

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-5808

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 12, 2024
@chronolaw chronolaw requested review from bungle and chobits November 12, 2024 02:03
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chronolaw do you think we can test this, or do we have tests for it somewhere alredy that could perhaps be copied here. I am not too worried about possible typo (that there isn’t), thus approved it. As expected no tests broke because of this, which is somewhat a signal that it is a good thing to do.

@chronolaw
Copy link
Contributor Author

@chronolaw do you think we can test this, or do we have tests for it somewhere alredy that could perhaps be copied here. I am not too worried about possible typo (that there isn’t), thus approved it. As expected no tests broke because of this, which is somewhat a signal that it is a good thing to do.

Currently I have no idea about testing it, leave it for later.

@ADD-SP ADD-SP merged commit 3d462b5 into master Nov 13, 2024
38 checks passed
@ADD-SP ADD-SP deleted the refactor/add_no_broadcast_crud_event_flag branch November 13, 2024 01:48
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13858-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13858-to-master-to-upstream
git checkout -b cherry-pick-13858-to-master-to-upstream
ancref=$(git merge-base af7c1749f87167bead492094e26a45ba06b3a755 44c0188dbf6b693c6cd8508d1f25ed40a4e290da)
git cherry-pick -x $ancref..44c0188dbf6b693c6cd8508d1f25ed40a4e290da

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 13, 2024
@chronolaw chronolaw added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention labels Nov 13, 2024
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants