Skip to content

Missing handling of plugin fields of type "json" in fillConfigRecord #524

Description

@zeteref

func fillConfigRecord(

deck gateway sync and deck gateway diff incorrectly print the result of the diff operation for plugins that declare any of their fields as type "json". This happens because the fillConfigRecord function does not handle those fields and, even when the field is set to a proper value, it updates it to null before performing the diff.

I have verified that a simple if added to this function solves the issue:


		if ftype.String() == "json" {
			if _, ok := config[fname]; ok {
				return true
			}
		}

but i'm unsure if that is the best way to solve it hence no pull request

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions