-
Notifications
You must be signed in to change notification settings - Fork 111
feat(orders): maker order recovery #2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
Signed-off-by: Onur Özkan <[email protected]>
01e814e to
06eec7b
Compare
… into lock-maker-orders
02d78b7 to
e1e5d38
Compare
Signed-off-by: Onur Özkan <[email protected]>
|
i call |
Nothing has changed in that regard, you can still do that. |
Signed-off-by: Onur Özkan <[email protected]>
I would like to add that this fix is done only for TPU which @cipig doesn't use yet. @cipig You will need to check if it works in a right way or not when testing TPU. |
… into lock-maker-orders
…is commit still needs refactoring and will be followed by a force push when done
b54e187 to
85274f6
Compare
85274f6 to
5613159
Compare
Fixes a bug where maker orders would get removed if swaps failed during the early negotiation phase. Before this change, when someone tried to take your order, the order would get immediately deleted from the orderbook. Which means, because of some unrelated issues (mostly coming from flaky taker peers) you would have to manually recreate it everytime.
The fix adds an order "locking" mechanism instead of immediate deletion. When a swap starts, the maker order gets moved to a locked state where it's temporarily hidden from the orderbook but not actually deleted entirely. If the swap completes successfully, the order gets permanently removed as expected. But if the swap fails or gets aborted, the order automatically gets recovered and put back in the orderbook with a fresh time state, so it shows up for other traders in the network again.
Feature is covered up with
test_maker_order_recovery_on_tputest with 3 nodes (Bob, Alice and Onur) and it's passing as expected.cc @KomodoPlatform/qa for GUI testing: Please test taking an order, aborting the swap from the taker side and then checking if that order gets recovered by viewing it from a 3rd node.